Skip to content

[RemoteModel] Skip test_hf_2_models test if hf_token is not defined #8989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davesh0812 merged 2 commits into from
Dec 4, 2025
Merged

[RemoteModel] Skip test_hf_2_models test if hf_token is not defined #8989

davesh0812 merged 2 commits into from
Dec 4, 2025
+2 −0

Conversation

@tomerm-iguazio
Copy link
Contributor

@tomerm-iguazio tomerm-iguazio commented Nov 30, 2025 •
edited by atlassian bot
Loading

📝 Description

test_hf_2_models failed because google/gemma-2b-it requires authentication via HF_TOKEN.

🛠️ Changes Made

If HF_TOKEN is not exist, skip the test.

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

🔗 References

  • Ticket link: ML-11614
  • Design docs links:
  • External links:

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

gtopper
gtopper reviewed Nov 30, 2025
View reviewed changes
gtopper
gtopper reviewed Nov 30, 2025
View reviewed changes
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@tomerm-iguazio @gtopper
Update tests/system/datastore/model_providers/test_huggingface.py
55368e3 
Co-authored-by: Gal Topper <gal.topper@gmail.com>
@davesh0812 davesh0812 merged commit 5323580 into mlrun:development Dec 4, 2025
13 checks passed
tomerm-iguazio added a commit to tomerm-iguazio/mlrun that referenced this pull request Dec 4, 2025
@tomerm-iguazio
[RemoteModel] Skip test_hf_2_models test if hf_token is not defined (m…
a1e11ff 
…lrun#8989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gtopper gtopper gtopper approved these changes

Assignees

No one assigned

Labels

area/system-tests area/tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomerm-iguazio @gtopper @davesh0812