[Setup] Python 3.11 alignment and cleanups #8981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
reviewed
Nov 27, 2025
Comment on lines
18
to
21
| [project.optional-dependencies] | ||
| kfp = [ | ||
| "kfp~=1.8.22; python_version < '3.11'", | ||
| "kfp~=1.8.23; python_version >= '3.11'", | ||
| "kfp~=1.8.23", | ||
| ] |
Member
There was a problem hiding this comment.
you bump the toml, need to bump the version as well
liranbg
requested changes
Nov 30, 2025
| [project] | ||
| name = "mlrun-pipelines-kfp-v1-8" | ||
| version = "0.5.8" | ||
| version = "0.5.9" |
| [project] | ||
| name = "mlrun-pipelines-kfp-v2" | ||
| version = "0.5.3" | ||
| version = "0.5.4" |
Member
There was a problem hiding this comment.
Suggested change
| version = "0.5.4" | |
| version = "0.6.0" |
Member
There was a problem hiding this comment.
the change you are doing here is not a "patch" modification but rather a minor since we now dropping backwards compatibility support of python 3.9 - meaning, at least updating minor here.
adamdelman
suggested changes
Nov 30, 2025
Contributor
adamdelman
left a comment
There was a problem hiding this comment.
Overall LGTM, minor comment.
liranbg
approved these changes
Nov 30, 2025
Eyal-Danieli
approved these changes
Nov 30, 2025
adamdelman
approved these changes
Nov 30, 2025
10 tasks
liranbg
pushed a commit
that referenced
this pull request
Dec 1, 2025
### 📝 Description Bump pipelines versions in requirements following the version bump done in : #8981 --- ### 🛠️ Changes Made <!-- - Key changes (e.g., added feature X, refactored Y, fixed Z) --> --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [ ] I have tested the changes in this PR - [ ] I confirmed whether my changes are covered by system tests - [ ] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [ ] I updated existing system tests and/or added new ones if needed to cover my changes - [ ] If I introduced a deprecation: - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md) - [ ] I updated the relevant Jira ticket for documentation --- ### 🧪 Testing <!-- - How it was tested (unit tests, manual, integration) --> <!-- - Any special cases covered. --> --- ### 🔗 References - Ticket link: Part of #8981 - Design docs links: - External links: --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [ ] No <!-- If yes, describe what needs to be changed downstream: --> --- ### 🔍️ Additional Notes <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### 📸 Screenshots / Logs -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR removes all remaining Python 3.9 support from the our codebase (following the PR: #8948 ).
🛠️ Changes Made
setup.pyand removing the Python 3.9 classifier.>=3.9, <3.12to>=3.11, <3.12StrEnumwith an alias to Python 3.11’s built-inenum.StrEnum_TDEngineColumnbecause the enum members hold _TDEngineColumnType objects not strings which StrEnum in Python 3.11 no longer accepts.✅ Checklist
🧪 Testing
Verified locally that installing MLRun under Python 3.9 fails as expected:
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes