[Nuclio] Raise error on multiple triggers + explicit ack + old nuclio #6363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assaf758
reviewed
Sep 19, 2024
Member
assaf758
left a comment
There was a problem hiding this comment.
looks good, one small coment.
assaf758
approved these changes
Sep 19, 2024
adamdelman
pushed a commit
to adamdelman/mlrun
that referenced
this pull request
Sep 19, 2024
…mlrun#6363) * [Nuclio] Raise error on multiple triggers + explicit ack + older nuclio [ML-7763](https://iguazio.atlassian.net/browse/ML-7763) * Update minimal nuclio version * [Nuclio] Raise error on multiple triggers + explicit ack + old nuclio [ML-7763](https://iguazio.atlassian.net/browse/ML-7763) * Remove redundant code
alonmr
reviewed
Sep 19, 2024
Comment on lines
+310
to
+312
| if mlconf.nuclio_version and semver.VersionInfo.parse( | ||
| mlconf.nuclio_version | ||
| ) < semver.VersionInfo.parse(min_nuclio_version): |
Contributor
There was a problem hiding this comment.
please use validate_component_version_compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML-7763