Adding hard shrink function by ojhalakshya · Pull Request #2186 · mlpack/mlpack

ojhalakshya · 2020-02-07T18:26:08Z

Hi, everyone I wanted to add the Hard Shrink Activation Function.
It can be refrenced from pytorch.
Just to mention ideal soft shrinkage has
lower minmax bound risk for small n but ideal hard shrinkage has lower minmax bound risk for large n.

kartikdutt18

Nice, I think this looks okay. I will take a closer look tomorrow.

src/mlpack/methods/ann/activation_functions/hardshrink_function.hpp

ojhalakshya · 2020-02-12T19:24:55Z

Hi @zoq I have also tried to keep this up to the format that you had asked me for my previous pr.
If you get a chance please have a look and kindly suggest any changes that I need to make.
Thanks.

zoq · 2020-02-12T19:56:53Z

Hi @zoq I have also tried to keep this up to the format that you had asked me for my previous pr.
If you get a chance please have a look and kindly suggest any changes that I need to make.
Thanks.

If you can implement the function in the form of another layer, that would be great. https://github.com/mlpack/mlpack/blob/master/src/mlpack/methods/ann/layer/elu.hpp is one example.

ojhalakshya · 2020-02-13T07:09:17Z

XD Forgot to push the code. Doing it now.

kartikdutt18 · 2020-02-13T07:11:18Z

No worries.

kartikdutt18

Hi @ojhalakshya, thanks for all the work, I have left some comments, other than that I think it's fine. Thanks.

src/mlpack/methods/ann/layer/hardshrink.hpp

src/mlpack/tests/activation_functions_test.cpp

zoq

If you can fix the minor issue, it's ready from my side.

zoq · 2020-02-25T21:25:45Z

src/mlpack/methods/ann/layer/hardshrink.hpp

+/**
+   * Create HardShrink object using specified hyperparameter lambda.
+   * 
+   * @param lambda is calculated by multiplying the


Picky style comment, the first word after the parameter should use upper casing.

* @param lambda Is calculated by multiplying the
Is this the correct way to do so?

That looks good, yes.

Thanks for the quick reply.
I have done the changes as above.

zoq · 2020-02-25T22:45:15Z

Also, let's wait for the test results before we merge this in, just to make sure we didn't miss anything.

ojhalakshya · 2020-02-26T06:02:51Z

@zoq
sure no problem.
Thanks.

ojhalakshya · 2020-02-26T20:33:50Z

@zoq
How to resolve the appveyor build fail?
I think all other tests have passed successfully.
Thanks.

mlpack-bot

Second approval provided automatically after 24 hours. 👍

mlpack-bot · 2020-03-03T16:54:21Z

Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in src/mlpack/core.hpp and COPYRIGHT.txt and you haven't already, please feel free to push a change to this PR---or, if it gets merged before you can, feel free to open another PR.

In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 👍

birm · 2020-03-03T17:11:56Z

@ojhalakshya does everything look to merge, or do you want to make any more revisions?

zoq · 2020-03-03T21:37:44Z

@zoq
How to resolve the appveyor build fail?
I think all other tests have passed successfully.
Thanks.

The appveyor timed-out, it's not related with the changes from the PR, so save to ignore.

kartikdutt18 · 2020-03-05T13:31:31Z

@ojhalakshya, Thanks for the changes. This looks fine to me too. 👍

* completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>

* completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de> * completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>

* completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de> * completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de> dummy commit Redirected link on NUMfocus logo test bugs fixing rebasing branch

* completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de> * completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de> dummy commit Redirected link on NUMfocus logo test bugs fixing rebasing branch dummy commit dummy commit 2

* Adding hard shrink function (#2186) * completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de> * completed hardshrink_function.hpp * resetting master * complete hardsrhink_function.hpp * activation_functions_test.cpp * cmake changes * base layer changes * style correction * starting implementing hard shrink as layer * new changes * changes in tests * inv changes * test changes * test changes * deleting prev function * test style changes * more style changes * comment changes * minor changes * comment corrections hard shrink * minor changes * dummy commit * Style fix for parameter lambda * hardshrink.hpp to hardshrink_impl.hpp fn function shift * style fix Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de> dummy commit Redirected link on NUMfocus logo test bugs fixing rebasing branch * rvalue refactor corrections edited copyright.txt changes in History.md bug fix * bug fixes minor change * dummy commit * style fix

ojhalakshya added 7 commits February 7, 2020 19:36

completed hardshrink_function.hpp

95de905

resetting master

ac2417a

complete hardsrhink_function.hpp

82a24ba

merging with local master

0ea68c2

activation_functions_test.cpp

99b8d36

cmake changes

bc00d81

base layer changes

85c67dc

mlpack-bot bot added s: needs review s: unanswered s: unlabeled labels Feb 7, 2020

style correction

d65f65e

kartikdutt18 reviewed Feb 7, 2020

View reviewed changes

zoq added c: methods t: added feature and removed s: unanswered s: unlabeled labels Feb 7, 2020

zoq reviewed Feb 7, 2020

View reviewed changes

src/mlpack/methods/ann/activation_functions/hardshrink_function.hpp Outdated Show resolved Hide resolved

kartikdutt18 mentioned this pull request Feb 8, 2020

Adding soft shrink function #2174

Merged

ojhalakshya added 5 commits February 12, 2020 19:45

starting implementing hard shrink as layer

09f660d

new changes

48fd733

changes in tests

0763541

inv changes

bcee112

test changes

e5ef98d

test changes

c5d2e56

deleting prev function

65a5bef

kartikdutt18 reviewed Feb 13, 2020

View reviewed changes

ojhalakshya added 4 commits February 22, 2020 15:47

minor changes

cf46cda

comment corrections hard shrink

252d926

minor changes

f431031

dummy commit

7e0bb19

zoq approved these changes Feb 25, 2020

View reviewed changes

Style fix for parameter lambda

c0995cc

mlpack-bot bot approved these changes Mar 3, 2020

View reviewed changes

mlpack-bot bot removed the s: needs review label Mar 3, 2020

ojhalakshya added 2 commits March 5, 2020 18:40

hardshrink.hpp to hardshrink_impl.hpp fn function shift

2a0adc7

style fix

e160df2

ojhalakshya requested a review from zoq March 7, 2020 19:47

birm merged commit 0d8c3a0 into mlpack:master Mar 8, 2020

favre49 mentioned this pull request Mar 13, 2020

Hard Shrink Activation Function does not comply to new method signatures #2287

Closed

Uh oh!

Conversation

ojhalakshya commented Feb 7, 2020

Uh oh!

kartikdutt18 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ojhalakshya commented Feb 12, 2020

Uh oh!

zoq commented Feb 12, 2020

Uh oh!

ojhalakshya commented Feb 13, 2020

Uh oh!

kartikdutt18 commented Feb 13, 2020

Uh oh!

kartikdutt18 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zoq left a comment

Choose a reason for hiding this comment

Uh oh!

zoq Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

ojhalakshya Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

zoq Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

ojhalakshya Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

zoq commented Feb 25, 2020

Uh oh!

ojhalakshya commented Feb 26, 2020

Uh oh!

ojhalakshya commented Feb 26, 2020

Uh oh!

mlpack-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

mlpack-bot bot commented Mar 3, 2020

Uh oh!

birm commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zoq commented Mar 3, 2020

Uh oh!

kartikdutt18 commented Mar 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

birm commented Mar 3, 2020 •

edited

Loading