add .gitignore for the python content#7
Merged
smurching merged 2 commits intomlflow:masterfrom Jun 6, 2018
Merged
Conversation
Collaborator
|
Thanks so much @ndjido for the PR! We definitely need a .gitignore, so I'm making a few small edits to the submitted file & merging - hope you don't mind and thanks again for the work :) |
20 tasks
jessechancy
added a commit
to jessechancy/mlflow
that referenced
this pull request
May 24, 2024
# This is the 1st commit message: add tracing to evaluate Signed-off-by: Jesse Chan <jesse.chan@databricks.com> monkeypatch with langchain Signed-off-by: Jesse Chan <jesse.chan@databricks.com> recursion fix Signed-off-by: Jesse Chan <jesse.chan@databricks.com> remove print Signed-off-by: Jesse Chan <jesse.chan@databricks.com> Autologging langchain config and cleanup Signed-off-by: Jesse Chan <jesse.chan@databricks.com> comment fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> wip Signed-off-by: Jesse Chan <jesse.chan@databricks.com> wip Signed-off-by: Jesse Chan <jesse.chan@databricks.com> fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> test import global Signed-off-by: Jesse Chan <jesse.chan@databricks.com> test fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#2: fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#3: fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#4: retrigger tests Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#5: remove copy to prevent retriggers Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#6: fixes + opt in langchain Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#7: fixed tests Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#8: added test for langchain not installed Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#9: add langchain-experimental package Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#10: Create copy of model.predict for tracing Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#11: fixed tests Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
jessechancy
added a commit
to jessechancy/mlflow
that referenced
this pull request
May 29, 2024
# This is the 1st commit message: add tracing to evaluate Signed-off-by: Jesse Chan <jesse.chan@databricks.com> monkeypatch with langchain Signed-off-by: Jesse Chan <jesse.chan@databricks.com> recursion fix Signed-off-by: Jesse Chan <jesse.chan@databricks.com> remove print Signed-off-by: Jesse Chan <jesse.chan@databricks.com> Autologging langchain config and cleanup Signed-off-by: Jesse Chan <jesse.chan@databricks.com> comment fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> wip Signed-off-by: Jesse Chan <jesse.chan@databricks.com> wip Signed-off-by: Jesse Chan <jesse.chan@databricks.com> fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> test import global Signed-off-by: Jesse Chan <jesse.chan@databricks.com> test fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#2: fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#3: fixes Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#4: retrigger tests Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#5: remove copy to prevent retriggers Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#6: fixes + opt in langchain Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#7: fixed tests Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#8: added test for langchain not installed Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#9: add langchain-experimental package Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#10: Create copy of model.predict for tracing Signed-off-by: Jesse Chan <jesse.chan@databricks.com> # This is the commit message mlflow#11: fixed tests Signed-off-by: Jesse Chan <jesse.chan@databricks.com>
nojaf
added a commit
to nojaf/mlflow
that referenced
this pull request
Jun 3, 2024
Enable go linters
B-Step62
added a commit
that referenced
this pull request
Jul 4, 2025
B-Step62
added a commit
that referenced
this pull request
Aug 7, 2025
Signed-off-by: B-Step62 <yuki.watanabe@databricks.com> Signed-off-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
alkispoly-db
added a commit
to alkispoly-db/mlflow
that referenced
this pull request
Dec 17, 2025
Implements 6 of 9 review comments from smoorjani: **API Simplification (Comment #1):** - Remove last_turn_scorer parameter from public API - Simplify constructor to use default Pydantic initialization - Parameter kept as internal field for composition pattern **Code Quality (Comments #3, mlflow#6, mlflow#8):** - Remove duplicated kwargs validation (already in base class) - Remove unnecessary one-line docstring from _evaluate_turn - Use CategoricalRating enum instead of string literals ("yes"/"no") **Logic Improvements (Comments mlflow#7, mlflow#9):** - Move empty results check from _compute_aggregate to __call__ - Add per-turn details for success case (symmetric with failure case) **Code Reuse Analysis (Comments mlflow#4, mlflow#5):** - Researched _validate_session: serves different purpose (session ID validation) - Researched resolve_conversation_from_session: returns different type (list[dict]) - Keeping inline implementations as they serve different purposes **Deferred (Comment #2):** - _create_judge() architecture issue deferred per reviewer (non-blocking) All 5 KnowledgeRetention tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Alkis Polyzotis <alkis.polyzotis@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need for .gitignore for the Python content. I add also ignored the VS code outputs and MAC
.DS_Storefolder.fixes #6