Skip to content

Clear "All" time selector when switching to overview tab#21371

Merged
daniellok-db merged 1 commit intomlflow:masterfrom
daniellok-db:fix/overview-page-all-time-label
Mar 4, 2026
Merged

Clear "All" time selector when switching to overview tab#21371
daniellok-db merged 1 commit intomlflow:masterfrom
daniellok-db:fix/overview-page-all-time-label

Conversation

@daniellok-db
Copy link
Collaborator

@daniellok-db daniellok-db commented Mar 4, 2026 •
edited
Loading

Related Issues/PRs

Closes | Relates to #issue_number

What changes are proposed in this pull request?

The overview tab disables "ALL" because we need to have a defined start time in order to construct the buckets. However, this option is not disabled in other tracing tabs and since the selection is preserved on navigation, this causes the charts page to error out. To fix, when the overview page loads, we reset the time selector to default if it is set to "ALL"

Before:

Screen.Recording.2026-03-04.at.7.27.25.PM.mov

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

After:

Screen.Recording.2026-03-04.at.7.16.43.PM.mov

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@daniellok-db @claude
Fix overview page crash when navigating with startTimeLabel=ALL
b7289e3 
The overview page excludes 'ALL' from the date selector since charts
require start_time_ms and end_time_ms. However, users could still
navigate to the page with ?startTimeLabel=ALL in the URL (e.g. from
another tab). This adds a guard that resets the time label back to
the default (7 days) when ALL is detected.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
@daniellok-db daniellok-db requested review from Copilot and serena-ruan and removed request for Copilot March 4, 2026 11:28
@github-actions github-actions bot added v3.10.1 size/S Small PR (10-49 LoC) labels Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21371/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21371/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/21371/merge

@github-actions github-actions bot added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs. labels Mar 4, 2026
serena-ruan
serena-ruan approved these changes Mar 4, 2026
View reviewed changes
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Documentation preview for b7289e3 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@daniellok-db daniellok-db enabled auto-merge March 4, 2026 11:40
@daniellok-db daniellok-db added this pull request to the merge queue Mar 4, 2026
Merged via the queue into mlflow:master with commit d75a55c Mar 4, 2026
29 of 31 checks passed
@daniellok-db daniellok-db deleted the fix/overview-page-all-time-label branch March 4, 2026 11:44
daniellok-db added a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
@daniellok-db @claude
Clear "All" time selector when switching to overview tab (mlflow#21371)
121d9f8 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Co-authored-by: Claude <noreply@anthropic.com>
daniellok-db added a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
@daniellok-db @claude
Clear "All" time selector when switching to overview tab (mlflow#21371)
9a6a475 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Co-authored-by: Claude <noreply@anthropic.com>
daniellok-db added a commit that referenced this pull request Mar 5, 2026
@daniellok-db @claude
Clear "All" time selector when switching to overview tab (#21371)
42d4356 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serena-ruan serena-ruan serena-ruan approved these changes

Assignees

No one assigned

Labels

area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs. size/S Small PR (10-49 LoC) v3.10.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daniellok-db @serena-ruan