Skip to content

Preserve time range between tabs#21264

Merged
serena-ruan merged 2 commits intomlflow:masterfrom
serena-ruan:fix_time_range
Mar 3, 2026
Merged

Preserve time range between tabs#21264
serena-ruan merged 2 commits intomlflow:masterfrom
serena-ruan:fix_time_range

Conversation

@serena-ruan
Copy link
Collaborator

@serena-ruan serena-ruan commented Mar 3, 2026

Related Issues/PRs

Closes | Relates to #issue_number

What changes are proposed in this pull request?

We should still preserve time range even after switching to judges/datasets/eval runs/... tabs.

Before:

Screen.Recording.2026-03-03.at.10.36.44.AM.mov

After:

Screen.Recording.2026-03-03.at.10.37.08.AM.mov

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@serena-ruan
preserve time range between tabs
25d33b7 
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Copilot AI review requested due to automatic review settings March 3, 2026 02:38
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21264/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21264/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/21264/merge

@github-actions github-actions bot added size/S Small PR (10-49 LoC) v3.10.1 rn/none List under Small Changes in Changelogs. labels Mar 3, 2026
Copilot AI reviewed Mar 3, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Preserves the experiment “time range” (URL query params like startTimeLabel) when navigating between additional experiment page tabs (e.g., Datasets / Evaluation Runs) via the side navigation.

Changes:

  • Expand the set of tabs treated as “traces-related” for query-param preservation.
  • Update sidebar navigation tests to assert query params are preserved when moving to/from evaluation tabs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
mlflow/server/js/src/experiment-tracking/pages/experiment-page-tabs/side-nav/utils.tsx Expands isTracesRelatedTab to include more tabs so navigation preserves the current URL query string.
mlflow/server/js/src/common/components/MlflowSidebarExperimentItems.test.tsx Updates assertions to expect query params to be preserved when navigating to/from Datasets.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026 •
edited
Loading

Documentation preview for f426c21 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@serena-ruan
update
f426c21 
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
daniellok-db
daniellok-db approved these changes Mar 3, 2026
View reviewed changes
Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@serena-ruan serena-ruan added this pull request to the merge queue Mar 3, 2026
Merged via the queue into mlflow:master with commit 4c06e1e Mar 3, 2026
18 of 20 checks passed
@serena-ruan serena-ruan deleted the fix_time_range branch March 3, 2026 05:10
@github-actions github-actions bot added size/M and removed size/S Small PR (10-49 LoC) labels Mar 3, 2026
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
@serena-ruan @daniellok-db
Preserve time range between tabs (mlflow#21264)
3d707fc 
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
@serena-ruan @daniellok-db
Preserve time range between tabs (mlflow#21264)
8edab79 
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
daniellok-db pushed a commit that referenced this pull request Mar 5, 2026
@serena-ruan @daniellok-db
Preserve time range between tabs (#21264)
7a8f379 
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@daniellok-db daniellok-db daniellok-db approved these changes

Assignees

No one assigned

Labels

mlflow-fix-it-q1fy27 rn/none List under Small Changes in Changelogs. size/M v3.10.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serena-ruan @daniellok-db