fix: DOM-based XSS in job and notebook source URLs by caponetto · Pull Request #21175 · mlflow/mlflow

caponetto · 2026-02-26T17:16:16Z

Related Issues/PRs

Closes #21231

What changes are proposed in this pull request?

Reuse existing isValidHttpUrl in getJobSourceUrl and getNotebookSourceUrl to reject non-http/https URI schemes, preventing DOM-based XSS (CWE-79) via javascript:, data:, or vbscript: URLs in dynamic href attributes
Add early return in renderJobSource and renderNotebookSource to fall back to plain text when the URL is unsafe
Add string | null type annotation to workspaceUrl parameters across all four affected functions
Add tests covering safe URLs, dangerous schemes, and render fallback behavior

How is this patch tested?

Unit tests verify that getJobSourceUrl and getNotebookSourceUrl return empty string for unsafe workspace URLs
Unit tests verify that renderJobSource and renderNotebookSource render plain text (no anchor tag) when given a malicious workspace URL

How is this PR tested?

Existing unit/integration tests
New unit/integration tests
Manual tests

Does this PR require documentation update?

Does this PR require updating the MLflow Skills repository?

No. You can skip the rest of this section.
Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release notes for MLflow users.

Fixed a DOM-based Cross-Site Scripting (XSS) vulnerability (CWE-79) where unsanitized workspace URLs could be injected into href attributes when rendering notebook and job source links. URLs are now validated to only allow http and https protocols; unsafe URLs are rendered as plain text instead of clickable links.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

How should the PR be classified in the release notes? Choose one:

rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
rn/feature - A new user-facing feature worth mentioning in the release notes
rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?

Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
Bug fixes, doc updates and new features usually go into minor releases.
Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
Bug fixes and doc updates usually go into patch releases.

Yes (this PR will be cherry-picked and included in the next patch release)
No (this PR will be included in the next minor release)

github-actions · 2026-02-26T17:16:30Z

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21175/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21175/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/21175/merge

Copilot

Pull request overview

This PR addresses a DOM-based Cross-Site Scripting (XSS) vulnerability (CWE-79) in the MLflow UI by adding URL sanitization for workspace URLs used in job and notebook source links. The vulnerability allowed attackers to inject malicious URLs with dangerous protocols (javascript:, data:, vbscript:) that would execute when users clicked on source links.

Changes:

Added sanitizeUrl() utility function that validates URLs to only allow http/https protocols
Applied sanitization to getJobSourceUrl() and getNotebookSourceUrl() to block dangerous workspace URLs
Updated renderJobSource() and renderNotebookSource() to render plain text instead of links when URLs fail sanitization
Added comprehensive test coverage for URL sanitization and fallback behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
mlflow/server/js/src/common/utils/Utils.tsx	Added sanitizeUrl function and applied it to getJobSourceUrl and getNotebookSourceUrl; updated render functions to handle empty URLs
mlflow/server/js/src/common/utils/Utils.test.tsx	Added comprehensive tests for sanitizeUrl, URL sanitization in get*SourceUrl functions, and render fallback behavior

github-actions · 2026-03-02T06:42:52Z

Documentation preview for e3a20b8 is available at:

https://pr-21175--mlflow-docs-preview.netlify.app/docs/latest/

More info

Ignore this comment if this PR does not change the documentation.
The preview is updated when a new commit is pushed to this PR.
This comment was created by this workflow run.
The documentation was built by this workflow run.

mlflow/server/js/src/common/utils/Utils.tsx

WeichenXu123

Overall good. Could you address the comment? and then I can approve and merge it.

mlflow/server/js/src/common/utils/Utils.test.tsx

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

caponetto · 2026-03-02T11:16:10Z

@WeichenXu123 Thanks for the review! Requested changes are in.

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 26, 2026 17:16

github-actions bot added community Community/external contribution size/M labels Feb 26, 2026

github-actions bot added v3.10.1 area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. labels Feb 26, 2026

Copilot started reviewing on behalf of caponetto February 26, 2026 17:16 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

caponetto mentioned this pull request Feb 28, 2026

fix: DOM-based XSS in job and notebook source URLs opendatahub-io/mlflow#154

Closed

3 tasks

WeichenXu123 reviewed Mar 2, 2026

View reviewed changes

mlflow/server/js/src/common/utils/Utils.tsx Outdated Show resolved Hide resolved

WeichenXu123 reviewed Mar 2, 2026

View reviewed changes

mlflow/server/js/src/common/utils/Utils.test.tsx Outdated Show resolved Hide resolved

github-actions bot assigned WeichenXu123 Mar 2, 2026

fix: DOM-based XSS in job and notebook source URLs

e3a20b8

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

caponetto force-pushed the fix-xss branch from 7b5e40c to e3a20b8 Compare March 2, 2026 11:11

WeichenXu123 approved these changes Mar 4, 2026

View reviewed changes

WeichenXu123 enabled auto-merge March 4, 2026 02:41

WeichenXu123 added this pull request to the merge queue Mar 4, 2026

Merged via the queue into mlflow:master with commit bd9f389 Mar 4, 2026
21 of 23 checks passed

daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026

fix: DOM-based XSS in job and notebook source URLs (mlflow#21175)

e4e7687

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026

fix: DOM-based XSS in job and notebook source URLs (mlflow#21175)

798579d

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

daniellok-db pushed a commit that referenced this pull request Mar 5, 2026

fix: DOM-based XSS in job and notebook source URLs (#21175)

289ecab

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

caponetto added a commit to caponetto/mlflow that referenced this pull request Mar 6, 2026

fix: DOM-based XSS in job and notebook source URLs (mlflow#21175)

661a022

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

caponetto mentioned this pull request Mar 6, 2026

Cherry-pick fixes for snyk from upstream opendatahub-io/mlflow#164

Merged

3 tasks

openshift-merge-bot bot pushed a commit to opendatahub-io/mlflow that referenced this pull request Mar 6, 2026

fix: DOM-based XSS in job and notebook source URLs (mlflow#21175)

fa6f891

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: DOM-based XSS in job and notebook source URLs#21175

fix: DOM-based XSS in job and notebook source URLs#21175
WeichenXu123 merged 1 commit intomlflow:masterfrom
caponetto:fix-xss

caponetto commented Feb 26, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 26, 2026

Install mlflow from this PR

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

WeichenXu123 left a comment

Uh oh!

Uh oh!

caponetto commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

caponetto commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues/PRs

What changes are proposed in this pull request?

How is this PR tested?

Does this PR require documentation update?

Does this PR require updating the MLflow Skills repository?

Release Notes

Is this a user-facing change?

What component(s), interfaces, languages, and integrations does this PR affect?

How should the PR be classified in the release notes? Choose one:

Should this PR be included in the next patch release?

Uh oh!

github-actions bot commented Feb 26, 2026

Install mlflow from this PR

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

WeichenXu123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

caponetto commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

caponetto commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading