Fix group mode to aggregate "Additional runs" as "Unassigned" group in charts#21155
Merged
WeichenXu123 merged 5 commits intomasterfrom Mar 4, 2026
Merged
Fix group mode to aggregate "Additional runs" as "Unassigned" group in charts#21155WeichenXu123 merged 5 commits intomasterfrom
WeichenXu123 merged 5 commits intomasterfrom
Conversation
…up in charts Co-authored-by: WeichenXu123 <19235986+WeichenXu123@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix display of additional runs in group mode
Fix group mode to aggregate "Additional runs" as "Unassigned" group in charts
Feb 26, 2026
11 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes grouped-run chart behavior in the experiment “compare runs” view by ensuring runs that lack the grouping attribute are charted as a single aggregated trace (labeled “Unassigned”) instead of multiple per-run traces.
Changes:
- Update compare-charts trace generation to aggregate all group headers (including the remaining-runs group) uniformly.
- Update remaining-runs group display name to return
"Unassigned"for chart legend/tooltip labeling. - Adjust unit/integration tests to include the remaining-runs group header and validate updated display names.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mlflow/server/js/src/experiment-tracking/components/runs-compare/RunsCompare.tsx | Removes special-casing so remaining-runs group is included as an aggregated group trace. |
| mlflow/server/js/src/experiment-tracking/components/runs-compare/RunsCompare.test.tsx | Updates mixed group/ungrouped test data shape to include remaining-runs group header. |
| mlflow/server/js/src/experiment-tracking/components/experiment-page/utils/experimentPage.group-row-utils.ts | Changes remaining-runs group display label to "Unassigned". |
| mlflow/server/js/src/experiment-tracking/components/experiment-page/utils/experimentPage.group-row-utils.test.ts | Updates assertions to expect "Unassigned" for remaining-runs group display name. |
mlflow/server/js/src/experiment-tracking/components/runs-compare/RunsCompare.test.tsx
Outdated
Show resolved
Hide resolved
mlflow/server/js/src/experiment-tracking/components/runs-compare/RunsCompare.tsx
Show resolved
Hide resolved
Contributor
|
Documentation preview for a7945ba is available at: More info
|
…re/RunsCompare.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: WeichenXu <weichen.xu@databricks.com>
…ns-compare/RunsCompare.tsx" This reverts commit f406b3e. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
daniellok-db
pushed a commit
to daniellok-db/mlflow
that referenced
this pull request
Mar 5, 2026
…n charts (mlflow#21155) Signed-off-by: WeichenXu <weichen.xu@databricks.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: WeichenXu123 <19235986+WeichenXu123@users.noreply.github.com> Co-authored-by: WeichenXu <weichen.xu@databricks.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
daniellok-db
pushed a commit
to daniellok-db/mlflow
that referenced
this pull request
Mar 5, 2026
…n charts (mlflow#21155) Signed-off-by: WeichenXu <weichen.xu@databricks.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: WeichenXu123 <19235986+WeichenXu123@users.noreply.github.com> Co-authored-by: WeichenXu <weichen.xu@databricks.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
daniellok-db
pushed a commit
that referenced
this pull request
Mar 5, 2026
…n charts (#21155) Signed-off-by: WeichenXu <weichen.xu@databricks.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: WeichenXu123 <19235986+WeichenXu123@users.noreply.github.com> Co-authored-by: WeichenXu <weichen.xu@databricks.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21129
In group mode, runs lacking the grouping attribute were placed in an "Additional runs" table group but rendered as individual traces in charts — inconsistent with how proper groups display as aggregated traces. This PR aggregates those runs into a single "Unassigned" group trace in all charts.
Changes
RunsCompare.tsx: Remove theisRemainingRunsGroupexclusion filter and the individual-run fallback mapping. All group headers (including the remaining runs group) are now passed throughcreateGroupDataTrace, so their metrics are aggregated uniformly.experimentPage.group-row-utils.ts:getRunGroupDisplayNamenow returns"Unassigned"for remaining-runs groups instead of"", giving the chart legend/tooltip a meaningful label.RunsCompare.test.tsx: Updated the mixed groups/ungrouped test to include the remaining runs group header incomparedRuns, matching the actual production data shape (the group header always accompanies its member runs).experimentPage.group-row-utils.test.ts: Updated display name assertions from""→"Unassigned".How is this PR tested?
Does this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
When grouping runs by a parameter/tag, runs without that attribute are now shown as a single aggregated "Unassigned" group trace in metric charts instead of individual per-run traces, consistent with how named groups are displayed.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.