Skip to content

Add MLFLOW_EXPERIMENT_IS_GATEWAY tag to gateway experiments#21149

Merged
TomeHirata merged 1 commit intomlflow:masterfrom
TomeHirata:gateway/experiment-tag
Feb 26, 2026
Merged

Add MLFLOW_EXPERIMENT_IS_GATEWAY tag to gateway experiments#21149
TomeHirata merged 1 commit intomlflow:masterfrom
TomeHirata:gateway/experiment-tag

Conversation

@TomeHirata
Copy link
Collaborator

@TomeHirata TomeHirata commented Feb 26, 2026

Related Issues/PRs

n/a

What changes are proposed in this pull request?

Currently mlflow doesn't return null value when negative filter is used for experiment tags. And because of it, we cannot exclude gateway experiments with sourceType tag since most experiments don't have this tag.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Copilot AI review requested due to automatic review settings February 26, 2026 05:21
@github-actions github-actions bot added the size/S Small PR (10-49 LoC) label Feb 26, 2026
@github-actions
Copy link
Contributor

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21149/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21149/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/21149/merge

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new experiment tag to identify experiments created for MLflow AI Gateway usage tracking, enabling downstream consumers (UI/filters/analytics) to reliably detect “gateway experiments”.

Changes:

  • Introduce MLFLOW_EXPERIMENT_IS_GATEWAY = "mlflow.experiment.isGateway" in the shared tags module.
  • Set mlflow.experiment.isGateway = "true" when the gateway store auto-creates an experiment during endpoint create/update.
  • Extend the existing SQL store test to assert the new tag on auto-created experiments.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
mlflow/utils/mlflow_tags.py Adds a constant for the new experiment tag key.
mlflow/store/tracking/gateway/sqlalchemy_mixin.py Applies the new tag during gateway experiment auto-creation in create/update flows.
tests/store/tracking/test_gateway_sql_store.py Verifies the new tag is present on an auto-created experiment.

Comment on lines 758 to 762
tags=[
ExperimentTag(MLFLOW_EXPERIMENT_SOURCE_TYPE, "GATEWAY"),
ExperimentTag(MLFLOW_EXPERIMENT_SOURCE_ID, endpoint_id),
ExperimentTag(MLFLOW_EXPERIMENT_IS_GATEWAY, "true"),
],
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MODERATE: This PR adds the mlflow.experiment.isGateway tag when update_gateway_endpoint() auto-creates an experiment, but there’s no test exercising the update flow where usage_tracking is enabled and an experiment is created implicitly. Adding a unit/integration test for that scenario would prevent regressions and verify the new tag (and existing sourceType/sourceId) are set correctly.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

Documentation preview for 07b8419 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@harupy
Copy link
Member

harupy commented Feb 26, 2026

@TomeHirata Can you update the PR description and explain why we need to add this?

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once #21149 (comment) is addressed!

Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@harupy
Copy link
Member

harupy commented Feb 26, 2026

@WeichenXu123 No need to add another stamp to a PR that’s already been approved.

@TomeHirata TomeHirata added this pull request to the merge queue Feb 26, 2026
Merged via the queue into mlflow:master with commit 7d491a6 Feb 26, 2026
67 of 70 checks passed
@TomeHirata TomeHirata deleted the gateway/experiment-tag branch February 26, 2026 07:54
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
daniellok-db pushed a commit that referenced this pull request Mar 5, 2026
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs. size/S Small PR (10-49 LoC) v3.10.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants