Skip to content

Replace MinIO with RustFS in docker-compose setup#21099

Merged
harupy merged 15 commits intomlflow:masterfrom
jmaggesi:docker-compose/examples
Feb 26, 2026
Merged

Replace MinIO with RustFS in docker-compose setup#21099
harupy merged 15 commits intomlflow:masterfrom
jmaggesi:docker-compose/examples

Conversation

@jmaggesi
Copy link
Contributor

@jmaggesi jmaggesi commented Feb 24, 2026

Related Issues/PRs

Resolve #20775

What changes are proposed in this pull request?

This PR removes the old Minio example in the docker-compose folder and add the RustFS as an alternative S3-compatible storage for artifacts.

The folder contains a .env example file and the docker compose required and updates also the doc

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions github-actions bot added community Community/external contribution size/XL Extra-large PR (500+ LoC) v3.10.1 labels Feb 24, 2026
@github-actions
Copy link
Contributor

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21099/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21099/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/21099/merge

@github-actions github-actions bot added the rn/documentation Mention under Documentation Changes in Changelogs. label Feb 24, 2026
@github-actions
Copy link
Contributor

@jmaggesi Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
@jmaggesi jmaggesi force-pushed the docker-compose/examples branch from aec8940 to 2be1563 Compare February 24, 2026 13:08
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
@github-actions github-actions bot added the area/docs Documentation issues label Feb 24, 2026
@harupy
Copy link
Member

harupy commented Feb 24, 2026

/title

@github-actions github-actions bot changed the title Docker compose/examples Add alternative S3-compatible storage examples (SeaweedFS, RustFS, Garage) to docker-compose setup Feb 24, 2026
@harupy harupy changed the title Add alternative S3-compatible storage examples (SeaweedFS, RustFS, Garage) to docker-compose setup Add alternative S3-compatible storage examples to docker-compose setup Feb 24, 2026
… doc

Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
@harupy harupy requested a review from Copilot February 24, 2026 14:37
@harupy
Copy link
Member

harupy commented Feb 24, 2026

/title

@harupy
Copy link
Member

harupy commented Feb 24, 2026

Let's update the PR description

@github-actions github-actions bot changed the title Add alternative S3-compatible storage examples to docker-compose setup Add S3-compatible storage alternatives (SeaweedFS, RustFS, Garage) to docker-compose setup Feb 24, 2026
@harupy
Copy link
Member

harupy commented Feb 24, 2026

Let's fix the lint check failure

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to replace MinIO with RustFS as the default S3-compatible storage in the MLflow docker-compose setup. However, the implementation does not match the PR description's promise to provide multiple S3-compatible storage examples.

Changes:

  • Replaced MinIO with RustFS in the docker-compose.yml
  • Updated documentation to reflect RustFS as the default storage backend
  • Modified environment variable configuration to support generic S3-compatible storage

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 14 comments.

File Description
docker-compose/docker-compose.yml Replaces MinIO service with RustFS, updates bucket creation logic to use AWS CLI
docker-compose/README.md Updates documentation claiming multiple backends available, but only RustFS is implemented
docker-compose/.env.dev.example Converts MinIO-specific variables to generic S3 variables, adds RustFS-specific config
docs/docs/self-hosting/index.mdx Updates the quick reference to mention RustFS instead of MinIO

@harupy
Copy link
Member

harupy commented Feb 24, 2026

/title

@github-actions github-actions bot changed the title Add S3-compatible storage alternatives (SeaweedFS, RustFS, Garage) to docker-compose setup Replace MinIO with RustFS in docker-compose setup Feb 24, 2026
@harupy
Copy link
Member

harupy commented Feb 24, 2026

Let's address copilot comments that are legit.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

Documentation preview for cfe4222 is available at:

Changed Pages (1)

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Jonatan Maggesi added 2 commits February 24, 2026 17:01
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
@jmaggesi
Copy link
Contributor Author

Ok, i've fixed the remarks from Copilot

Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
---

## How It Works (at a Glance)
### Bucket Bootstrap (idempotent)
Copy link
Member

@harupy harupy Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to add this in this PR? Let's focus on replacing minio, not extending the existing contents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added here some comments just to let know the user what is the behaviour of the compose, but it's easy enough to check it directly in the compose file.

I can remove from line 183 to line 200 and leave the other comments about troubleshooting so from line 201 it should be ok

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

docs/docs/self-hosting/index.mdx:72

  • 🟡 MODERATE: The self-hosting quickstart commands use cd docker-compose, but in the MLflow repo the directory is mlflow/docker-compose after cloning. Update the snippet so it works when copied/pasted.
The MLflow repository includes a ready-to-run Compose project under `docker-compose/` that provisions MLflow, PostgreSQL, and [RustFS](https://github.com/rustfs/rustfs).

```bash
git clone https://github.com/mlflow/mlflow.git
cd docker-compose

- **MLflow Tracking Server** — exposed on your host (default `http://localhost:5000`).
- **PostgreSQL** — persists MLflow's metadata (experiments, runs, params, metrics).
- **MinIO** — stores run artifacts via an S3-compatible API.
All variants share the same architecture:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does variants refer to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a comment referring to the other examples that i've put there before with SeaweedFS and Garage.

I've already removed in my local this one, i will check the other comments and remove the section in the readme

@harupy
Copy link
Member

harupy commented Feb 25, 2026

@jmaggesi Left some comments. Can you address them?

…le, fixed some typo in README

Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
@jmaggesi
Copy link
Contributor Author

Done, i can remove more in the README about the troubleshooting if it's not the case and fixed some typo that were still referring to the other examples that i've removed from the folder

@@ -1,6 +1,8 @@
version: "3.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is deprecated in Docker Compose v2+ and emits a warning. The original file correctly omitted it — let's remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Jonatan Maggesi added 2 commits February 25, 2026 14:14
…rage, variables alignment, removed typos in README.md

Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Jonatan Maggesi and others added 3 commits February 25, 2026 14:55
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
- Remove unnecessary historical note about MinIO
- Fix awkward phrasing and typos in README
- Rename rustfs-data volume to storage-data for generality

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested e2e: all services (PostgreSQL, RustFS, create-bucket, MLflow) come up healthy, and logging params/metrics/artifacts works correctly. LGTM.

@harupy harupy added this pull request to the merge queue Feb 26, 2026
Merged via the queue into mlflow:master with commit ef95c70 Feb 26, 2026
50 of 53 checks passed
@github-actions github-actions bot added size/L Large PR (200-499 LoC) and removed size/XL Extra-large PR (500+ LoC) labels Feb 26, 2026
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: Jonatan Maggesi <jmaggesi@gmail.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: Jonatan Maggesi <jmaggesi@gmail.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
daniellok-db pushed a commit that referenced this pull request Mar 5, 2026
Signed-off-by: Jonatan Maggesi <jmaggesi@gmail.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: Jonatan Maggesi <jmaggesi@gmail.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation issues community Community/external contribution rn/documentation Mention under Documentation Changes in Changelogs. size/L Large PR (200-499 LoC) v3.10.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC-FIX] Move away from MinIO in docker compose setup

3 participants