Fix visibility toggle button in chart tooltip not working#21071
Merged
B-Step62 merged 1 commit intomlflow:masterfrom Feb 27, 2026
Merged
Fix visibility toggle button in chart tooltip not working#21071B-Step62 merged 1 commit intomlflow:masterfrom
B-Step62 merged 1 commit intomlflow:masterfrom
Conversation
The visibility toggle button in RunsChartsTooltipWrapper was not correctly hiding/showing runs because the onHideRun callback was not passing the current visibility state to the underlying toggleRunVisibility function. When isCurrentlyVisible is not provided, the code does `!isCurrentlyVisible` which becomes `!undefined` = `true`, causing the run to always be set to visible instead of toggling. Changes: - Update onHideRun interface to accept isCurrentlyVisible parameter - Pass activeRun.hidden state when calling onHideRun from tooltip - Update RunsCompare callback to pass visibility state through Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Contributor
🛠 DevTools 🛠
Install mlflow from this PRFor Databricks, use the following command: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the run visibility toggle in the runs charts tooltip by correctly passing the current visibility state through the onHideRun callback so useToggleRowVisibilityCallback can compute the next visibility value properly.
Changes:
- Updates
onHideRuncallback signature inRunsCompareto acceptisCurrentlyVisibleand forwards it totoggleRunVisibility. - Updates
RunsChartsTooltipBody’s context contract foronHideRunto include the visibility argument. - Passes
!activeRun.hiddenfrom the tooltip visibility button to ensure correct toggling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mlflow/server/js/src/experiment-tracking/components/runs-compare/RunsCompare.tsx | Propagates isCurrentlyVisible into the visibility toggle callback used by the tooltip. |
| mlflow/server/js/src/experiment-tracking/components/runs-charts/components/RunsChartsTooltipBody.tsx | Extends tooltip context callback typing and passes current visibility state on click. |
Contributor
|
Documentation preview for 84526bc is available at: More info
|
daniellok-db
added a commit
to daniellok-db/mlflow
that referenced
this pull request
Mar 5, 2026
Signed-off-by: Daniel Lok <daniel.lok@databricks.com> Co-authored-by: Claude <noreply@anthropic.com>
daniellok-db
added a commit
to daniellok-db/mlflow
that referenced
this pull request
Mar 5, 2026
Signed-off-by: Daniel Lok <daniel.lok@databricks.com> Co-authored-by: Claude <noreply@anthropic.com>
daniellok-db
added a commit
that referenced
this pull request
Mar 5, 2026
Signed-off-by: Daniel Lok <daniel.lok@databricks.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#21046What changes are proposed in this pull request?
Fix the visibility toggle button in
RunsChartsTooltipWrapperwhich was not correctly hiding/showing runs.Root cause: The
onHideRuncallback was not passing the current visibility state to the underlyingtoggleRunVisibilityfunction. WhenisCurrentlyVisibleis not provided, the code does!isCurrentlyVisiblewhich becomes!undefined=true, causing the run to always be set to visible instead of toggling.Changes:
onHideRuninterface to acceptisCurrentlyVisibleparameter!activeRun.hiddenstate when callingonHideRunfrom tooltip buttonRunsComparecallback to pass visibility state through totoggleRunVisibilityHow is this PR tested?
Verified that the visibility toggle button now correctly hides runs when clicked in the chart tooltip.
Screen.Recording.2026-02-23.at.2.54.41.PM.mov
Does this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
Fix visibility toggle button in chart tooltip not correctly hiding runs.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?