Skip to content

disable openai agents tracing by default#21038

Merged
bbqiu merged 10 commits intomlflow:masterfrom
bbqiu:bbqiu/disable-openai-agents-trace
Mar 2, 2026
Merged

disable openai agents tracing by default#21038
bbqiu merged 10 commits intomlflow:masterfrom
bbqiu:bbqiu/disable-openai-agents-trace

Conversation

@bbqiu
Copy link
Collaborator

@bbqiu bbqiu commented Feb 21, 2026

Related Issues/PRs

https://github.com/mlflow/mlflow/pull/18562/changes
openai/openai-agents-python#1387 (comment)

What changes are proposed in this pull request?

  • disable openai-agents-sdk tracing by default

Warning

The CUJ of exporting traces to the openai platform when using Databricks LLMs does not work, even when you fill in the OPENAI_API_KEY env var because of schema misalignment:

Error when valid `OPENAI_API_KEY` and using Databricks LLM ``` ERROR:openai.agents:[non-fatal] Tracing client error 400: { "error": { "message": "Unknown parameter: 'data[0].span_data.usage.total_tokens'.", "type": "invalid_request_error", "param": "data[0].span_data.usage.total_tokens", "code": "unknown_parameter" } } ```

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Databricks LLM CUJ, export to both MLflow and OpenAI (set OPENAI_API_KEY):

before and after dont work due to schema misalignment:

ERROR:openai.agents:[non-fatal] Tracing client error 400: {
  "error": {
    "message": "Unknown parameter: 'data[0].span_data.usage.total_tokens'.",
    "type": "invalid_request_error",
    "param": "data[0].span_data.usage.total_tokens",
    "code": "unknown_parameter"
  }
}

Databricks LLM CUJ, export only to MLflow

before:

ERROR:openai.agents:[non-fatal] Tracing client error 401: {
  "error": {
    "message": "Incorrect API key provided: no-token. You can find your API key at https://platform.openai.com/account/api-keys.",
    "type": "invalid_request_error",
    "param": null,
    "code": "invalid_api_key"
  }
}

after: no errors in the logs bc the openai agents sdk is disabled by default

Use OpenAI LLM, export to both MLflow and OpenAI

before and after both work. manual test after:
my openai traces console:
image

mlflow traces:
image

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@github-actions
Copy link
Contributor

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21038/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/21038/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/21038/merge

@github-actions github-actions bot added the size/L Large PR (200-499 LoC) label Feb 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

Documentation preview for b0cad1e is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Signed-off-by: bbqiu <bryan.qiu@databricks.com>
.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@github-actions github-actions bot added v3.10.1 area/tracking Tracking service, tracking client APIs, autologging area/tracing MLflow Tracing and its integrations rn/none List under Small Changes in Changelogs. and removed area/tracking Tracking service, tracking client APIs, autologging rn/none List under Small Changes in Changelogs. labels Feb 23, 2026
.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu bbqiu requested a review from B-Step62 February 23, 2026 04:05
@bbqiu
Copy link
Collaborator Author

bbqiu commented Feb 23, 2026

/review


🚀 Review workflow started


✅ Review completed.

Review Output

I've completed the PR review for PR #21038: disable openai agents tracing by default.

Summary

The PR adds a disable_openai_agent_tracer parameter to mlflow.openai.autolog() that defaults to True, which clears the OpenAI Agent SDK's trace processors to avoid 401 authentication errors when users don't have a valid OPENAI_API_KEY set.

Issue Found

I identified 1 issue and left a review comment:

mlflow/openai/autolog.py:96-101 - The refactored logic no longer considers the log_traces parameter for the agent tracer. Previously, add_mlflow_trace_processor() was only called when log_traces=True and not disable. Now it's called whenever disable=False, ignoring the log_traces setting entirely. This could lead to inconsistent behavior when a user explicitly sets log_traces=False.

Review comment: #21038 (comment)

.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu bbqiu requested a review from daniellok-db February 25, 2026 01:11
.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu bbqiu requested a review from serena-ruan March 2, 2026 03:19
.
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu bbqiu enabled auto-merge March 2, 2026 03:24
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bbqiu bbqiu added this pull request to the merge queue Mar 2, 2026
Merged via the queue into mlflow:master with commit 3f2036b Mar 2, 2026
65 of 66 checks passed
@bbqiu bbqiu deleted the bbqiu/disable-openai-agents-trace branch March 2, 2026 04:00
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
daniellok-db pushed a commit that referenced this pull request Mar 5, 2026
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracing MLflow Tracing and its integrations rn/none List under Small Changes in Changelogs. size/M v3.10.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants