Fix admonition link underlines not rendering#20990
Merged
Conversation
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix admonition link underline not rendering
Fix admonition link underlines not rendering due to CSS Modules hash mismatch
Feb 19, 2026
9 tasks
Member
|
@copilot Thanks! In the PR description, I only see the after screenshots. |
Copilot
AI
changed the title
Fix admonition link underlines not rendering due to CSS Modules hash mismatch
Fix admonition link underlines not rendering
Feb 19, 2026
harupy
approved these changes
Feb 19, 2026
harupy
reviewed
Feb 19, 2026
docs/src/css/custom.css
Outdated
| /* Style admonition links to match main content */ | ||
| .admonition a { | ||
| color: var(--ifm-border-color); | ||
| /* Style admonition links to be visible with underline */ |
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
|
Documentation preview for 2c0439d is available at: More info
|
daniellok-db
pushed a commit
to daniellok-db/mlflow
that referenced
this pull request
Feb 20, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
daniellok-db
pushed a commit
that referenced
this pull request
Feb 20, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#20616 (comment)
What changes are proposed in this pull request?
Links in Docusaurus admonition blocks (warnings, notes, tips) lacked underlines, making them difficult to distinguish from regular text.
Root cause: The CSS selector
.admonition anever matched. Docusaurus CSS Modules hash class names toadmonition_xJq3, not.admonition.Fix: Changed selector to
.theme-admonition a(stable, non-hashed Docusaurus class) and addedtext-decoration: underline;.Before:
After:
How is this PR tested?
Verified on
/docs/latest/self-hosting/architecture/backend-store/with built documentation. Links in all admonition types now render with underlines. Links outside admonitions unchanged.Does this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
Fixed links inside documentation admonition blocks (warnings, notes, tips) lacking underlines, making them easier to identify.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/bug-fix- A user-facing bug fix worth mentioning in the release notesShould this PR be included in the next patch release?
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.