Skip to content

Fix admonition link underlines not rendering#20990

Merged
harupy merged 3 commits intomasterfrom
copilot/fix-admonition-link-underline
Feb 19, 2026
Merged

Fix admonition link underlines not rendering#20990
harupy merged 3 commits intomasterfrom
copilot/fix-admonition-link-underline

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

Related Issues/PRs

#20616 (comment)

What changes are proposed in this pull request?

Links in Docusaurus admonition blocks (warnings, notes, tips) lacked underlines, making them difficult to distinguish from regular text.

Root cause: The CSS selector .admonition a never matched. Docusaurus CSS Modules hash class names to admonition_xJq3, not .admonition.

Fix: Changed selector to .theme-admonition a (stable, non-hashed Docusaurus class) and added text-decoration: underline;.

-/* Style admonition links to match main content */
-.admonition a {
-  color: var(--ifm-border-color);
+/* Add underline to admonition links for better visibility */
+.theme-admonition a {
+  text-decoration: underline;
 }
 
-.admonition a:hover {
+.theme-admonition a:hover {
   color: var(--ifm-color-emphasis-hover);
 }

Before:

After:

image

How is this PR tested?

  • Manual tests

Verified on /docs/latest/self-hosting/architecture/backend-store/ with built documentation. Links in all admonition types now render with underlines. Links outside admonitions unchanged.

Does this PR require documentation update?

  • No. You can skip the rest of this section.

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.

Release Notes

Is this a user-facing change?

  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Fixed links inside documentation admonition blocks (warnings, notes, tips) lacking underlines, making them easier to identify.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@harupy harupy marked this pull request as ready for review February 19, 2026 07:05
Copilot AI review requested due to automatic review settings February 19, 2026 07:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix admonition link underline not rendering Fix admonition link underlines not rendering due to CSS Modules hash mismatch Feb 19, 2026
Copilot AI requested a review from harupy February 19, 2026 07:14
@harupy harupy requested a review from B-Step62 February 19, 2026 07:15
@github-actions github-actions bot added area/docs Documentation issues rn/bug-fix Mention under Bug Fixes in Changelogs. v3.10.0 labels Feb 19, 2026
@harupy
Copy link
Member

harupy commented Feb 19, 2026

@copilot Thanks! In the PR description, I only see the after screenshots.

Copilot AI changed the title Fix admonition link underlines not rendering due to CSS Modules hash mismatch Fix admonition link underlines not rendering Feb 19, 2026
@mlflow mlflow deleted a comment from Copilot AI Feb 19, 2026
/* Style admonition links to match main content */
.admonition a {
color: var(--ifm-border-color);
/* Style admonition links to be visible with underline */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Links were visible but lacking underline. Adjust the comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment to be more accurate: "Add underline to admonition links for better visibility" (2c0439d)

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI requested a review from harupy February 19, 2026 07:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026

Documentation preview for 2c0439d is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@harupy harupy added this pull request to the merge queue Feb 19, 2026
Merged via the queue into master with commit 347430e Feb 19, 2026
22 checks passed
@harupy harupy deleted the copilot/fix-admonition-link-underline branch February 19, 2026 08:08
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Feb 20, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
daniellok-db pushed a commit that referenced this pull request Feb 20, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation issues rn/bug-fix Mention under Bug Fixes in Changelogs. size/XS v3.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants