Skip to content

Display notebook trace viewer when workspace is on#20947

Merged
TomeHirata merged 2 commits intomlflow:masterfrom
TomeHirata:fix/workspace/trace-viewer
Feb 19, 2026
Merged

Display notebook trace viewer when workspace is on#20947
TomeHirata merged 2 commits intomlflow:masterfrom
TomeHirata:fix/workspace/trace-viewer

Conversation

@TomeHirata
Copy link
Collaborator

@TomeHirata TomeHirata commented Feb 18, 2026 •
edited
Loading

Related Issues/PRs

n/a

What changes are proposed in this pull request?

Fix the issue that trace viewer on notebooks is not displayed due to the lack of workspace header when workspace is enabled on the tracking server.

image

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@TomeHirata
Display notebook trace viewer when workspace is on
15b2771 
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
@TomeHirata TomeHirata requested review from Copilot and daniellok-db and removed request for Copilot February 18, 2026 04:35
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20947/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20947/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20947/merge

@github-actions github-actions bot added the size/S Small PR (10-49 LoC) label Feb 18, 2026
@TomeHirata TomeHirata requested a review from B-Step62 February 18, 2026 04:36
@github-actions github-actions bot added v3.10.0 area/tracing MLflow Tracing and its integrations rn/bug-fix Mention under Bug Fixes in Changelogs. labels Feb 18, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026 •
edited
Loading

Documentation preview for 1fa7a95 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@TomeHirata
Update query parameter in trace link generation for ModelTraceExplore…
1fa7a95 
…rOSSNotebookRenderer

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Copilot AI review requested due to automatic review settings February 18, 2026 05:01
TomeHirata
TomeHirata commented Feb 18, 2026
View reviewed changes
...-shared/model-trace-explorer/oss-notebook-renderer/ModelTraceExplorerOSSNotebookRenderer.tsx
const getMlflowUILinkForTrace = (traceId: string, experimentId: string) => {
const queryParams = new URLSearchParams();
queryParams.append('selectedTraceId', traceId);
queryParams.append('selectedEvaluationId', traceId);
Copy link
Collaborator Author

@TomeHirata TomeHirata Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this has been broken regardless of workspace change. I wonder why we're using "selectedEvaluationId" for trace id.

Copy link
Collaborator

@daniellok-db daniellok-db Feb 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm weird, i wonder when this changed ah i think this was in the trace v2 -> v3 page migration. regardless thank you for fixing!

Copilot AI reviewed Feb 18, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an issue where the trace viewer in Jupyter notebooks was not displaying correctly when workspace functionality is enabled on the MLflow tracking server. The fix ensures that workspace context is properly propagated through both the Python backend (when generating iframe URLs) and the JavaScript frontend (when initializing the trace viewer).

Changes:

  • Added workspace query parameter to notebook iframe URLs when workspace is set
  • Set workspace context in the notebook renderer bootstrap before rendering
  • Corrected the trace link URL to use the proper /traces route and selectedEvaluationId query parameter

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
mlflow/tracing/display/display_handler.py Added workspace query parameter to iframe URL when workspace context is available
tests/tracing/display/test_ipython.py Added test to verify workspace parameter is included in iframe HTML
mlflow/server/js/src/shared/web-shared/model-trace-explorer/oss-notebook-renderer/bootstrap.tsx Extract workspace from URL and set it before rendering to ensure API calls include workspace header
mlflow/server/js/src/shared/web-shared/model-trace-explorer/oss-notebook-renderer/ModelTraceExplorerOSSNotebookRenderer.tsx Fixed trace link URL to use correct route path and query parameter, added workspace to query params

daniellok-db
daniellok-db approved these changes Feb 19, 2026
View reviewed changes
Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TomeHirata TomeHirata added this pull request to the merge queue Feb 19, 2026
Merged via the queue into mlflow:master with commit 73409d4 Feb 19, 2026
69 of 71 checks passed
@TomeHirata TomeHirata deleted the fix/workspace/trace-viewer branch February 19, 2026 04:19
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Feb 20, 2026
@TomeHirata @daniellok-db
Display notebook trace viewer when workspace is on (mlflow#20947)
fb20692 
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
daniellok-db pushed a commit that referenced this pull request Feb 20, 2026
@TomeHirata @daniellok-db
Display notebook trace viewer when workspace is on (#20947)
7b6efd8 
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@daniellok-db daniellok-db daniellok-db approved these changes

@B-Step62 B-Step62 Awaiting requested review from B-Step62

Assignees

@daniellok-db daniellok-db

Labels

area/tracing MLflow Tracing and its integrations rn/bug-fix Mention under Bug Fixes in Changelogs. size/S Small PR (10-49 LoC) v3.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomeHirata @daniellok-db