Skip to content

Skip workspace header when workspace is disabled#20904

Merged
TomeHirata merged 1 commit intomlflow:masterfrom
TomeHirata:fix/ui/gateway-stale-state
Feb 17, 2026
Merged

Skip workspace header when workspace is disabled#20904
TomeHirata merged 1 commit intomlflow:masterfrom
TomeHirata:fix/ui/gateway-stale-state

Conversation

@TomeHirata
Copy link
Collaborator

@TomeHirata TomeHirata commented Feb 17, 2026 •
edited
Loading

Related Issues/PRs

n/a

What changes are proposed in this pull request?

There is an issue that when users switch from workspace enabled to disabled, the workspace header continues to be passed, leading to the crash everywhere. This PR fixes it by checking the server info first.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Does this PR require updating the MLflow Skills repository?

  • No. You can skip the rest of this section.
  • Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@TomeHirata
Skip workspace header when workspace is disabled
95ef4a4 
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
@TomeHirata TomeHirata requested a review from harupy February 17, 2026 00:51
@github-actions github-actions bot added size/XS area/build Build and test infrastructure for MLflow rn/bug-fix Mention under Bug Fixes in Changelogs. labels Feb 17, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20904/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20904/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20904/merge

@TomeHirata TomeHirata mentioned this pull request Feb 17, 2026
Merged
31 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Documentation preview for 95ef4a4 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@TomeHirata TomeHirata requested a review from B-Step62 February 17, 2026 01:09
harupy
harupy approved these changes Feb 17, 2026
View reviewed changes
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TomeHirata TomeHirata added this pull request to the merge queue Feb 17, 2026
Merged via the queue into mlflow:master with commit aa3bd83 Feb 17, 2026
27 of 29 checks passed
@TomeHirata TomeHirata deleted the fix/ui/gateway-stale-state branch February 17, 2026 01:31
daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Feb 20, 2026
@TomeHirata @daniellok-db
Skip workspace header when workspace is disabled (mlflow#20904)
f289127 
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
daniellok-db pushed a commit that referenced this pull request Feb 20, 2026
@TomeHirata @daniellok-db
Skip workspace header when workspace is disabled (#20904)
d783798 
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harupy harupy harupy approved these changes

@B-Step62 B-Step62 Awaiting requested review from B-Step62

Assignees

No one assigned

Labels

area/build Build and test infrastructure for MLflow rn/bug-fix Mention under Bug Fixes in Changelogs. size/XS v3.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomeHirata @harupy