Trace UI papercut: highlight searched text and change search box hint's wording. by PattaraS · Pull Request #20841 · mlflow/mlflow

PattaraS · 2026-02-16T05:38:00Z

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Changes the search box's hint in Traces and Sessions tab from "Search traces by request" --> "Search traces by id, request, or response"
Makes it so that searched text is highlighted.
Use trace.text in place of span.attributes.mlflow.spanInputs when searching.

How is this PR tested?

Existing unit/integration tests
New unit/integration tests
Manual tests

Screen.Recording.2026-02-16.at.12.41.29.PM.mov

Does this PR require documentation update?

Does this PR require updating the MLflow Skills repository?

No. You can skip the rest of this section.
Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release notes for MLflow users.

Changes the search box's hint in Traces and Sessions tab from "Search traces by request" to "Search traces by id, request, or response" to match its behavior.
Searched text in Traces and Sessions tab is now highlighted.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

How should the PR be classified in the release notes? Choose one:

rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
rn/feature - A new user-facing feature worth mentioning in the release notes
rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?

Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
Bug fixes, doc updates and new features usually go into minor releases.
Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
Bug fixes and doc updates usually go into patch releases.

Yes (this PR will be cherry-picked and included in the next patch release)
No (this PR will be included in the next minor release)

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

github-actions · 2026-02-16T05:38:11Z

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20841/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20841/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20841/merge

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

github-actions · 2026-02-16T05:48:21Z

Documentation preview for e53f7c4 is available at:

https://pr-20841--mlflow-docs-preview.netlify.app/docs/latest/

More info

Ignore this comment if this PR does not change the documentation.
The preview is updated when a new commit is pushed to this PR.
This comment was created by this workflow run.
The documentation was built by this workflow run.

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

PattaraS · 2026-02-17T08:36:07Z

/autoformat

…ighlight

Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>

TomeHirata · 2026-02-17T08:42:51Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableSearchInput.tsx

        placeholder ??
        intl.formatMessage({
-          defaultMessage: 'Search traces by request',
+          defaultMessage: 'Search traces by id, request, and response',


Can we add a comment that this is an OSS behavior and Databricks still continues to search by request only?

TomeHirata

Overall LGTM

Copilot

Pull request overview

This PR improves the trace search functionality in the MLflow UI by updating the search box placeholder text to better reflect its capabilities, highlighting matched text in search results, and switching from searching within span.attributes.mlflow.spanInputs to the more comprehensive trace.text field.

Changes:

Updated search box placeholder text from "Search traces by request" to "Search traces by id, request, and response"
Added text highlighting functionality to visually mark search matches in the Request, Response, and Trace ID columns
Changed backend search filter from span.attributes.mlflow.spanInputs to trace.text for broader search coverage

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/store/tracking/test_sqlalchemy_store.py	Updated tests to use `trace.text` instead of `span.attributes.mlflow.spanInputs`
mlflow/server/js/src/shared/web-shared/genai-traces-table/utils/DisplayUtils.tsx	Added `highlightSearchInText()` function to wrap matched text in `<mark>` tags
mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useMlflowTraces.tsx	Changed filter to use `trace.text` instead of `span.attributes.mlflow.spanInputs`
mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useMlflowTraces.test.tsx	Updated test expectations for new filter syntax
mlflow/server/js/src/shared/web-shared/genai-traces-table/cellRenderers/rendererFunctions.tsx	Integrated search highlighting for Request, Response, and Trace ID columns
mlflow/server/js/src/shared/web-shared/genai-traces-table/cellRenderers/SessionHeaderCellRenderers.tsx	Added search highlighting support for session headers
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableSessionGroupedRows.tsx	Passed searchQuery prop through component hierarchy
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableSearchInput.tsx	Updated placeholder text to reflect broader search capabilities
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBody.utils.tsx	Extracted searchQuery from table metadata for cell renderers
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBody.tsx	Added searchQuery to table metadata
mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAITracesTableBodyContainer.tsx	Added searchQuery prop and passed it to table body
mlflow/server/js/src/lang/default/en.json	Updated localization strings for new placeholder text
mlflow/server/js/src/experiment-tracking/components/experiment-page/components/traces-v3/TracesV3Logs.tsx	Passed searchQuery prop to table container
mlflow/server/js/src/experiment-tracking/components/experiment-page/components/traces-v3/TracesV3Logs.intg.test.tsx	Updated test to expect new placeholder text
mlflow/server/js/src/experiment-tracking/components/experiment-logged-models/ExperimentLoggedModelDetailsTraces.test.tsx	Updated test to expect new placeholder text

Copilot · 2026-02-17T08:45:16Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useMlflowTraces.tsx

  }
  if (searchQuery) {
-    filter.push(`span.attributes.\`mlflow.spanInputs\` ILIKE '%${searchQuery}%'`);
+    filter.push(`trace.text ILIKE '%${searchQuery}%'`);


The search query is directly interpolated into the filter string without escaping special characters. This could cause the filter to break if users search for text containing single quotes (') or percent signs (%).

According to the Python tests (e.g., test_sqlalchemy_store.py line 5197), single quotes in filter strings need to be escaped as ' and percent signs as %%. Consider adding an escaping function to handle these characters before building the filter string.

For example:

A search for "it's working" would generate: trace.text ILIKE '%it's working%' which would break the SQL syntax

A search for "90%" would generate: trace.text ILIKE '%90%%' but the percent sign in the search term should be escaped as %%

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-02-17T08:45:16Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableSearchInput.tsx

        placeholder ??
        intl.formatMessage({
-          defaultMessage: 'Search traces by request',
+          defaultMessage: 'Search traces by id, request, and response',


There's a discrepancy between the PR description and the actual code change. The PR description states the placeholder text should be "Search traces by id, request, or response" (using "or"), but the code implements "Search traces by id, request, and response" (using "and"). Additionally, the release notes mention "Search traces by request & response" which differs from both.

Please clarify which wording is intended and ensure consistency across the PR description, release notes, and code.

Changed from "and response" to "or response".

Copilot · 2026-02-17T08:45:16Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/cellRenderers/rendererFunctions.tsx

            <div css={{ overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }} title={value}>
-              {value}
+              {displayValue}
            </div>
          ) : (
            <NullCell isComparing={isComparing} />
          )
        }
        second={
          isComparing &&
-          (otherValue ? (
+          (displayOtherValue ? (
            <div css={{ overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }} title={otherValue}>


The title attribute should check if the value is a string before using it, similar to how it's done in SessionHeaderCellRenderers.tsx (lines 447, 459, 478). While formatResponseTitle() should return a string, adding a type guard would make the code more defensive and consistent with the rest of the codebase.

Consider changing:

title={value} to title={typeof value === 'string' ? value : undefined}

title={otherValue} to title={typeof otherValue === 'string' ? otherValue : undefined}

Current behavior, so ignoring this.

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

PattaraS · 2026-02-17T09:04:45Z

/autoformat

Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>

…'s wording. (mlflow#20841) Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com> Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com> Co-authored-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>

…'s wording. (#20841) Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com> Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com> Co-authored-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>

PattaraS added 2 commits February 16, 2026 11:35

Change search box hint

9332762

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

Highlight searched text

b1ce4af

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

github-actions bot added size/M area/tracing MLflow Tracing and its integrations rn/none List under Small Changes in Changelogs. labels Feb 16, 2026

PattaraS requested a review from TomeHirata February 16, 2026 05:41

PattaraS self-assigned this Feb 16, 2026

Pretiter

5788aec

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

yarn i18n

aa3c947

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

github-actions bot added rn/bug-fix Mention under Bug Fixes in Changelogs. v3.10.0 and removed rn/none List under Small Changes in Changelogs. labels Feb 16, 2026

PattaraS added 3 commits February 16, 2026 13:11

Fix text in corresponding tests

563870b

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

Use trace.text in place of span.attributes.mlflow.spanInputs

b2bb04a

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

Change wording and highlight trace id

fd8dd2a

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

PattaraS changed the title ~~Trace UI papercut 2 highlight~~ Trace UI papercut: highlight searched text and change search box hint's wording. Feb 17, 2026

TomeHirata requested a review from Copilot February 17, 2026 08:40

Copilot started reviewing on behalf of TomeHirata February 17, 2026 08:41 View session

mlflow-app bot added 2 commits February 17, 2026 08:41

Merge remote-tracking branch 'base/master' into trace-ui-papercut-2-h…

1a9ed4b

…ighlight

Autoformat: https://github.com/mlflow/mlflow/actions/runs/22091400157

10e0fc3

Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>

TomeHirata reviewed Feb 17, 2026

View reviewed changes

TomeHirata approved these changes Feb 17, 2026

View reviewed changes

Copilot AI reviewed Feb 17, 2026

View reviewed changes

PattaraS enabled auto-merge February 17, 2026 09:00

PattaraS disabled auto-merge February 17, 2026 09:01

correct wording and clarify discrepancy between OSS and Databricks

f83a7d4

Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>

Autoformat: https://github.com/mlflow/mlflow/actions/runs/22092237189

e53f7c4

Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>

PattaraS enabled auto-merge February 17, 2026 09:12

github-actions bot assigned TomeHirata Feb 17, 2026

PattaraS added this pull request to the merge queue Feb 17, 2026

Merged via the queue into mlflow:master with commit 0f19559 Feb 17, 2026
55 of 57 checks passed

PattaraS deleted the trace-ui-papercut-2-highlight branch February 17, 2026 09:54

Copilot AI mentioned this pull request Feb 19, 2026

Fix: Escape single quotes in trace search filter strings #20983

Open

9 tasks

Conversation

PattaraS commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues/PRs

What changes are proposed in this pull request?

How is this PR tested?

Does this PR require documentation update?

Does this PR require updating the MLflow Skills repository?

Release Notes

Is this a user-facing change?

What component(s), interfaces, languages, and integrations does this PR affect?

How should the PR be classified in the release notes? Choose one:

Should this PR be included in the next patch release?

Uh oh!

github-actions bot commented Feb 16, 2026

Install mlflow from this PR

Uh oh!

github-actions bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PattaraS commented Feb 17, 2026

Uh oh!

TomeHirata Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

PattaraS Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

TomeHirata left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

PattaraS Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

PattaraS Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

PattaraS Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

PattaraS commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PattaraS commented Feb 16, 2026 •

edited

Loading

github-actions bot commented Feb 16, 2026 •

edited

Loading