Use github installation for dockerfile from dev version by TomeHirata · Pull Request #20740 · mlflow/mlflow

TomeHirata · 2026-02-12T02:56:11Z

Related Issues/PRs

https://github.com/mlflow/dev/actions/runs/21907088804/job/63250153366

What changes are proposed in this pull request?

2a3b04fc7 removed virtualenv from the dockerfile, but the latest released version still requires it.

How is this PR tested?

Existing unit/integration tests
New unit/integration tests
Manual tests

Does this PR require documentation update?

Does this PR require updating the MLflow Skills repository?

No. You can skip the rest of this section.
Yes. Please link the corresponding PR or explain how you plan to update it.

Release Notes

Is this a user-facing change?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

How should the PR be classified in the release notes? Choose one:

rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
rn/feature - A new user-facing feature worth mentioning in the release notes
rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?

Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
Bug fixes, doc updates and new features usually go into minor releases.
Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
Bug fixes and doc updates usually go into patch releases.

Yes (this PR will be cherry-picked and included in the next patch release)
No (this PR will be included in the next minor release)

… setup This update includes the addition of 'RUN pip install virtualenv' to multiple Dockerfiles to ensure that the virtualenv package is installed, facilitating better environment management across different setups. Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

github-actions · 2026-02-12T02:56:24Z

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20740/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20740/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20740/merge

Copilot

Pull request overview

This PR aims to unblock Docker image builds for MLflow’s virtualenv-based images by ensuring virtualenv is installed during image build, aligning the generated Dockerfile template and test Dockerfile fixtures.

Changes:

Add RUN pip install virtualenv to multiple Dockerfile fixtures used in tests.
Add RUN pip install virtualenv to the Ubuntu/pyenv setup snippet in mlflow/models/docker_utils.py so generated Dockerfiles include it.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/resources/dockerfile/Dockerfile_sagemaker_virtualenv_no_java	Installs `virtualenv` in the fixture image build steps.
tests/resources/dockerfile/Dockerfile_sagemaker_virtualenv	Installs `virtualenv` in the fixture image build steps.
tests/resources/dockerfile/Dockerfile_no_model_uri	Installs `virtualenv` in the fixture image build steps.
tests/resources/dockerfile/Dockerfile_java_flavor	Installs `virtualenv` in the fixture image build steps.
tests/resources/dockerfile/Dockerfile_install_mlflow_virtualenv	Installs `virtualenv` in the fixture image build steps.
mlflow/models/docker_utils.py	Ensures generated Ubuntu-based Dockerfiles install `virtualenv`.

tests/resources/dockerfile/Dockerfile_sagemaker_virtualenv_no_java

tests/resources/dockerfile/Dockerfile_sagemaker_virtualenv

tests/resources/dockerfile/Dockerfile_no_model_uri

tests/resources/dockerfile/Dockerfile_java_flavor

tests/resources/dockerfile/Dockerfile_install_mlflow_virtualenv

mlflow/models/docker_utils.py

github-actions · 2026-02-12T03:05:26Z

Documentation preview for 35af770 is available at:

https://pr-20740--mlflow-docs-preview.netlify.app/docs/latest/

More info

Ignore this comment if this PR does not change the documentation.
The preview is updated when a new commit is pushed to this PR.
This comment was created by this workflow run.
The documentation was built by this workflow run.

harupy · 2026-02-12T03:46:39Z

mlflow/models/docker_utils.py

Let's fix the root cause. The same issue happens again if we remove a dependency again. We can consider installing dev mlflow in Dockerfile in CI or while testing.

The same issue happens again if we remove a dependency again We can consider installing dev mlflow in Dockerfile in CI or while testing

Is it a test-only issue? Doesn't it happen when users create a Dockerfile using the dev version? We could install dev MLFlow if the dev version is used then (not only for CI or testing), but not sure if that's also an ideal behavior.

Good question. MLflow version used in dockerfile is defined here:

mlflow/mlflow/models/docker_utils.py

Line 190 in 8948d54

return f"# Install MLflow\nRUN pip install mlflow=={VERSION}"

In >= 3.10, mlflow no longer requires virtualenv
In < 3.10, they have pip install virtualenv

I wonder if VERSION becomes < 3.10. Let's double check

Actually the dev version was used when generate-dockerfile command is called for the dev version, so the feature didn't work. I think installing the dev version from github is probably the expected behavior, wdyt?

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

…tualenv

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

harupy

LGTM!

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

…lflow#20740) Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

…20740) Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

Copilot AI review requested due to automatic review settings February 12, 2026 02:56

github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. v3.9.1 labels Feb 12, 2026

Copilot started reviewing on behalf of TomeHirata February 12, 2026 02:56 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

harupy reviewed Feb 12, 2026

View reviewed changes

github-actions bot assigned harupy Feb 12, 2026

TomeHirata requested a review from harupy February 12, 2026 07:31

TomeHirata added 3 commits February 12, 2026 18:52

Use master branch for dev versions

1e56cdc

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

Merge branch 'master' of github.com:mlflow/mlflow into fix/docker-vir…

17ee3b6

…tualenv

lint

8f9768e

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

harupy approved these changes Feb 12, 2026

View reviewed changes

test

35af770

Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

TomeHirata merged commit b19301b into mlflow:master Feb 12, 2026
49 of 51 checks passed

TomeHirata changed the title ~~Add back virtualenv to fix the docker build until the next release~~ Use github master for dockerfile from dev version Feb 13, 2026

TomeHirata changed the title ~~Use github master for dockerfile from dev version~~ Use github installation for dockerfile from dev version Feb 13, 2026

daniellok-db pushed a commit to daniellok-db/mlflow that referenced this pull request Mar 5, 2026

Add back virtualenv to fix the docker build until the next release (m…

009264e

…lflow#20740) Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

daniellok-db pushed a commit that referenced this pull request Mar 5, 2026

Add back virtualenv to fix the docker build until the next release (#…

3d17d6c

…20740) Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>

Conversation

TomeHirata commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues/PRs

What changes are proposed in this pull request?

How is this PR tested?

Does this PR require documentation update?

Does this PR require updating the MLflow Skills repository?

Release Notes

Is this a user-facing change?

What component(s), interfaces, languages, and integrations does this PR affect?

How should the PR be classified in the release notes? Choose one:

Should this PR be included in the next patch release?

Uh oh!

github-actions bot commented Feb 12, 2026

Install mlflow from this PR

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harupy Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomeHirata Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harupy Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomeHirata Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harupy Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

harupy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TomeHirata commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

harupy Feb 12, 2026 •

edited

Loading

TomeHirata Feb 12, 2026 •

edited

Loading

harupy Feb 12, 2026 •

edited

Loading

TomeHirata Feb 12, 2026 •

edited

Loading