Include git submodule contents in Python package build#20394
Merged
Conversation
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inclusion of git submodule in Python package build
Include git submodule contents in Python package build
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing mlflow/assistant/skills git submodule files in built/distributed Python packages by explicitly including them as setuptools package data.
Changes:
- Added
assistant/skills/**/*totool.setuptools.package-datafor the main MLflow package. - Regenerated
pyproject.tomlandpyproject.release.tomlfromdev/pyproject.pyto include the new package-data entry. - Updated the skinny package’s generated
libs/skinny/pyproject.tomlto include the same skills package data.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
dev/pyproject.py |
Adds the assistant/skills/**/* package-data glob in the generator so all derived pyproject files include the submodule contents. |
pyproject.toml |
Includes the new skills glob in tool.setuptools.package-data for the main build. |
pyproject.release.toml |
Includes the new skills glob for release builds. |
libs/skinny/pyproject.toml |
Includes the new skills glob for the skinny package build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Documentation preview for bc1b1d0 is available at: More info
|
harupy
added a commit
to harupy/mlflow
that referenced
this pull request
Jan 28, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
added a commit
to harupy/mlflow
that referenced
this pull request
Jan 28, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
added a commit
that referenced
this pull request
Jan 28, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Git submodules are not automatically detected by Python build tools. The
mlflow/assistant/skillssubmodule contains skill files (markdown documentation, Python scripts) that were missing from distributed packages.Changes:
"assistant/skills/**/*"to package data configuration indev/pyproject.pypyproject.tomlandpyproject.release.tomlwith the updated patternVerification:
The wheel now includes all 22 files from the submodule (LICENSE, README, skill documentation, evaluation scripts, and utilities).
How is this PR tested?
Built the package and verified submodule contents are present:
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Fixed missing
mlflow/assistant/skillssubmodule files in distributed packages. Users installing MLflow from PyPI will now have access to assistant skill functionality.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/build: Build and test infrastructure for MLflowHow should the PR be classified in the release notes? Choose one:
rn/bug-fix- A user-facing bug fix worth mentioning in the release notesShould this PR be included in the next patch release?
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.