Fix temperature/json issues with ConversationSimulator on managed#20236
Merged
smoorjani merged 2 commits intomlflow:masterfrom Jan 27, 2026
Merged
Conversation
f464e02 to
9613fbd
Compare
44af55e to
c515c4f
Compare
c515c4f to
127810b
Compare
Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
127810b to
fcd3636
Compare
smoorjani
approved these changes
Jan 26, 2026
Contributor
🛠 DevTools 🛠
Install mlflow from this PRFor Databricks, use the following command: |
Contributor
|
Documentation preview for 5a7ae5c is available at: More info
|
dbczumar
reviewed
Jan 26, 2026
Comment on lines
+205
to
+206
| # Drop unsupported params (e.g., temperature=0 for certain models) | ||
| "drop_params": True, |
Collaborator
There was a problem hiding this comment.
@xsh310 @smoorjani @TomeHirata can we. define some standardized utilities for this stuff? I worry we have multiple LiteLLM call sites with different combinations of arguments throughout the code base
Collaborator
Author
There was a problem hiding this comment.
@dbczumar Yes, agree. @smoorjani and I also discussed this. I think the long term solution would be to make our invocation adapters to be MLflow-level util and not eval-specific, and refactor this to use invocation adapters.
This would be a larger refactor and it's probably better to decouple these changes in separate PRs. I can add a ticket to keep track of this action item.
harupy
pushed a commit
to harupy/mlflow
that referenced
this pull request
Jan 28, 2026
…flow#20236) Signed-off-by: Xiang Shen <xshen.shc@gmail.com> Co-authored-by: Samraj Moorjani <samrajmoorjani@gmail.com>
harupy
pushed a commit
to harupy/mlflow
that referenced
this pull request
Jan 28, 2026
…flow#20236) Signed-off-by: Xiang Shen <xshen.shc@gmail.com> Co-authored-by: Samraj Moorjani <samrajmoorjani@gmail.com>
harupy
pushed a commit
that referenced
this pull request
Jan 28, 2026
…0236) Signed-off-by: Xiang Shen <xshen.shc@gmail.com> Co-authored-by: Samraj Moorjani <samrajmoorjani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
We currently have a few issues when running conversation simulator on managed with FMAPI.
One issue is related to temperature, in conversation simulator we are setting the temperature param to 0.0 which is not supported for models like gpt-5. We have
drop_paramsflags set to true for LiteLLM which works for OpenAI native api, but it does not seem to address the issue for datarbricks-managed models.Another issue is related to json parsing, for models like
databricks-claude-sonnet-4-5, the goal check returns non-json format consistently.Both issues fails the goal check and the conversation simulation will continue until the max_turn is hit.
This PR adds a retry logic when the LiteLLM completion call returns a temperature error and also adds response format to the goal check.
How is this PR tested?
Manual Testing
Tested with databricks notebook: https://e2-dogfood.staging.cloud.databricks.com/editor/notebooks/2791734932961460?o=6051921418418893
Verified goal check works for databricks default model

Verified goal check works for databricks gpt-5 model

Verified goal check works for databricks claude sonnet model

Verfieid goal check works for databricks gemini 3 pro model

Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.