Skip to content

Fix tool name extraction for tool call correctness#20201

Merged
smoorjani merged 2 commits intomlflow:masterfrom
smoorjani:gwt-toolcorrectness-name
Jan 22, 2026
Merged

Fix tool name extraction for tool call correctness#20201
smoorjani merged 2 commits intomlflow:masterfrom
smoorjani:gwt-toolcorrectness-name

Conversation

@smoorjani
Copy link
Collaborator

Related Issues/PRs

#20043

Resolve #20043

What changes are proposed in this pull request?

As titled - fixes the tool name extraction for our judges

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests
import mlflow
from mlflow.entities import SpanType
from mlflow.genai.scorers.deepeval import ToolCorrectness

mlflow.set_tracking_uri("sqlite:///test_wrapper.db")
mlflow.set_experiment("wrapper_test")


@mlflow.trace
def agent_with_wrapper_tool(query: str):
    # Simulate a wrapper tool call like FastMCPToolset creates
    with mlflow.start_span(name="ToolManager.handle_call", span_type=SpanType.TOOL) as span:
        span.set_inputs({"call": {"tool_name": "list_client", "args": {"param": query}}})
        result = {"clients": ["client_a", "client_b"]}
        span.set_outputs(result)
    return f"Found clients for: {query}"


# Create a trace
response = agent_with_wrapper_tool("test query")
print(f"Agent response: {response}\n")

# Retrieve the trace
traces = mlflow.search_traces(experiment_ids=["1"])
trace_id = traces.iloc[0]["trace_id"]
trace = mlflow.get_trace(trace_id)

# Show what's in the trace
tool_spans = trace.search_spans(span_type=SpanType.TOOL)
print("Tool spans in trace:")
for span in tool_spans:
    print(f"  span.name: '{span.name}'")
    print(f"  inputs: {span.inputs}")

# Test with ToolCorrectness scorer
print("\n--- Testing ToolCorrectness scorer ---")
scorer = ToolCorrectness()

expectations = {
    "expected_tool_calls": [{"name": "list_client"}]
}

result = scorer(
    inputs={"query": "test query"},
    outputs={"response": response},
    expectations=expectations,
    trace=trace,
)

print(f"\nScorer result:")
print(f"  {result}")

results:

Tool spans in trace:
  span.name: 'ToolManager.handle_call'
  inputs: {'call': {'tool_name': 'list_client', 'args': {'param': 'test query'}}}

--- Testing ToolCorrectness scorer ---

Scorer result:
  Feedback(name='ToolCorrectness', source=AssessmentSource(source_type='LLM_JUDGE', source_id='openai:/gpt-4.1-mini'), trace_id=None, run_id=None, rationale="[\n\t Tool Calling Reason: All expected tools ['list_client'] were called (order not considered).\n\t Tool Selection Reason: No available tools were provided to assess tool selection criteria\n]\n", metadata={'score': 1.0, 'threshold': 0.5, 'mlflow.scorer.framework': 'deepeval'}, span_id=None, create_time_ms=1769038707044, last_update_time_ms=1769038707044, assessment_id=None, error=None, expectation=None, feedback=FeedbackValue(value=<CategoricalRating.YES: 'yes'>, error=None), overrides=None, valid=True)

Note that before the fix, this judge returned NO

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Fix tool name extraction which impacted the ToolCallCorrectness scorer.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20201/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20201/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20201/merge

@github-actions github-actions bot added v3.9.0 area/evaluation MLflow Evaluation rn/bug-fix Mention under Bug Fixes in Changelogs. labels Jan 21, 2026
@smoorjani smoorjani requested review from TomeHirata and daniellok-db and removed request for TomeHirata January 21, 2026 23:46
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Documentation preview for fca1221 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, thanks for the fix!

Signed-off-by: Samraj Moorjani <samraj.moorjani@databricks.com>
.
Signed-off-by: Samraj Moorjani <samraj.moorjani@databricks.com>
@smoorjani smoorjani force-pushed the gwt-toolcorrectness-name branch from 90243f6 to fca1221 Compare January 22, 2026 04:52
@smoorjani smoorjani added this pull request to the merge queue Jan 22, 2026
Merged via the queue into mlflow:master with commit d006471 Jan 22, 2026
46 checks passed
@smoorjani smoorjani deleted the gwt-toolcorrectness-name branch January 22, 2026 05:59
harupy pushed a commit to harupy/mlflow that referenced this pull request Jan 28, 2026
Signed-off-by: Samraj Moorjani <samraj.moorjani@databricks.com>
harupy pushed a commit to harupy/mlflow that referenced this pull request Jan 28, 2026
Signed-off-by: Samraj Moorjani <samraj.moorjani@databricks.com>
harupy pushed a commit that referenced this pull request Jan 28, 2026
Signed-off-by: Samraj Moorjani <samraj.moorjani@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation rn/bug-fix Mention under Bug Fixes in Changelogs. v3.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ToolCorrectness behavior with toolset wrappers

2 participants