Auto-navigate to Events tab when clicking error spans by anshuman-sahu · Pull Request #20188 · mlflow/mlflow

anshuman-sahu · 2026-01-21T13:47:41Z

Related Issues/PRs

20187

Resolve #20187

What changes are proposed in this pull request?

This PR adds the functionality to auto-navigate to the Events tab when users click on spans with errors in the Tracing UI.

How is this PR tested?

Existing unit/integration tests
New unit/integration tests
Manual tests

Before:-

before.mp4

After:-

after.mp4

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

How should the PR be classified in the release notes? Choose one:

rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
rn/feature - A new user-facing feature worth mentioning in the release notes
rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?

Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
Bug fixes, doc updates and new features usually go into minor releases.
Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
Bug fixes and doc updates usually go into patch releases.

Yes (this PR will be cherry-picked and included in the next patch release)
No (this PR will be included in the next minor release)

Signed-off-by: Anshuman Sahu <anshumansahu18@gmail.com>

github-actions · 2026-01-21T13:48:03Z

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20188/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20188/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20188/merge

Copilot

Pull request overview

This PR adds functionality to auto-navigate to the Events tab when users click on spans with errors in the Tracing UI. This improves user experience by automatically displaying error details when an error span is selected.

Changes:

Modified TimelineTree.tsx to detect error conditions on span click and navigate to Events tab
Updated ModelTraceExplorerViewStateContext.tsx to automatically switch to Events tab when a node with errors is selected

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`mlflow/server/js/src/shared/web-shared/model-trace-explorer/timeline-tree/TimelineTree.tsx`	Adds error detection logic in `onSpanClick` callback to navigate to Events tab when error spans are clicked
`mlflow/server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorerViewStateContext.tsx`	Adds useEffect hook to auto-navigate to Events tab when selectedNode has errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T13:57:52Z

mlflow/server/js/src/shared/web-shared/model-trace-explorer/timeline-tree/TimelineTree.tsx

+    const hasError = 
+      node.status?.code === 'STATUS_CODE_ERROR' ||
+      node.status?.status_code === 'STATUS_CODE_ERROR' ||
+      (node.events && node.events.length > 0 && 
+        node.events.some(event => 
+          event.name === 'exception' || 
+          event.attributes?.['exception.type']
+        ));


The error detection logic here is duplicated in ModelTraceExplorerViewStateContext.tsx (lines 142-150). Consider extracting this logic into a shared utility function to improve maintainability and ensure consistency. For example, create a function like hasSpanError(node: ModelTraceSpanNode): boolean in ModelTraceExplorer.utils.tsx.

.../server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorerViewStateContext.tsx

Copilot · 2026-01-21T13:57:53Z

.../server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorerViewStateContext.tsx

    const defaultActiveTab = getDefaultActiveTab(selectedNode);
    setActiveTab(defaultActiveTab);
+  }
  }, [selectedNode]);


The useEffect hook is missing setActiveTab in its dependency array. According to React Hooks rules, all values from the component scope that are used inside the effect should be included in the dependency array. Add setActiveTab to the dependency array to fix this exhaustive-deps warning.

Suggested change

}, [selectedNode]);

}, [selectedNode, setActiveTab]);

mlflow/server/js/src/shared/web-shared/model-trace-explorer/timeline-tree/TimelineTree.tsx

github-actions · 2026-01-21T14:02:30Z

Documentation preview for 48a321d is available at:

https://pr-20188--mlflow-docs-preview.netlify.app/docs/latest/

More info

Ignore this comment if this PR does not change the documentation.
The preview is updated when a new commit is pushed to this PR.
This comment was created by this workflow run.
The documentation was built by this workflow run.

.../server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorerViewStateContext.tsx

Use getSpanExceptionCount in getDefaultActiveTab instead of duplicating error detection logic in multiple places. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

harupy · 2026-01-23T00:22:46Z

mlflow/server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorer.utils.tsx

+  // Auto-navigate to events tab when span has errors
+  if (getSpanExceptionCount(selectedNode) > 0) {
+    return 'events';
+  }


@daniellok-db applied your suggestion. It works!

joelrobin18

Can we add a test case as well?

Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

harupy

Added a test case for the error span auto-navigation in getDefaultActiveTab tests.

joelrobin18

LGTM

Signed-off-by: Anshuman Sahu <anshumansahu18@gmail.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>

Auto-navigate to Events tab when clicking error spans

4f18512

Signed-off-by: Anshuman Sahu <anshumansahu18@gmail.com>

github-actions bot added area/tracing MLflow Tracing and its integrations rn/feature Mention under Features in Changelogs. labels Jan 21, 2026

harupy requested a review from Copilot January 21, 2026 13:53

Copilot started reviewing on behalf of harupy January 21, 2026 13:54 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

harupy requested review from daniellok-db and hubertzub-db January 21, 2026 14:07

harupy reviewed Jan 21, 2026

View reviewed changes

.../server/js/src/shared/web-shared/model-trace-explorer/ModelTraceExplorerViewStateContext.tsx Show resolved Hide resolved

github-actions bot assigned harupy Jan 21, 2026

Merge branch 'master' into error-span-navigate

14fd538

github-actions bot assigned daniellok-db Jan 22, 2026

Simplify error span auto-navigation using existing utility

c253597

Use getSpanExceptionCount in getDefaultActiveTab instead of duplicating error detection logic in multiple places. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

harupy requested a review from joelrobin18 January 23, 2026 00:22

harupy reviewed Jan 23, 2026

View reviewed changes

joelrobin18 reviewed Jan 23, 2026

View reviewed changes

Add test for error span auto-navigation to Events tab

48a321d

Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

harupy reviewed Jan 23, 2026

View reviewed changes

harupy requested a review from joelrobin18 January 23, 2026 00:32

joelrobin18 approved these changes Jan 23, 2026

View reviewed changes

daniellok-db approved these changes Jan 23, 2026

View reviewed changes

harupy added the v3.9.0 label Jan 23, 2026

harupy added this pull request to the merge queue Jan 23, 2026

Merged via the queue into mlflow:master with commit 95cad56 Jan 23, 2026
60 of 63 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-navigate to Events tab when clicking error spans#20188

Auto-navigate to Events tab when clicking error spans#20188
harupy merged 4 commits intomlflow:masterfrom
anshuman-sahu:error-span-navigate

anshuman-sahu commented Jan 21, 2026 •

edited by harupy

Loading

Uh oh!

github-actions bot commented Jan 21, 2026

Install mlflow from this PR

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 21, 2026

Uh oh!

Uh oh!

Copilot AI Jan 21, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

harupy Jan 23, 2026

Uh oh!

joelrobin18 left a comment

Uh oh!

harupy left a comment

Uh oh!

joelrobin18 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

anshuman-sahu commented Jan 21, 2026 • edited by harupy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues/PRs

What changes are proposed in this pull request?

How is this PR tested?

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

What component(s), interfaces, languages, and integrations does this PR affect?

How should the PR be classified in the release notes? Choose one:

Should this PR be included in the next patch release?

Uh oh!

github-actions bot commented Jan 21, 2026

Install mlflow from this PR

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

harupy Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

joelrobin18 left a comment

Choose a reason for hiding this comment

Uh oh!

harupy left a comment

Choose a reason for hiding this comment

Uh oh!

joelrobin18 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anshuman-sahu commented Jan 21, 2026 •

edited by harupy

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading