Support shift+select for Traces by B-Step62 · Pull Request #20125 · mlflow/mlflow

B-Step62 · 2026-01-19T12:27:04Z

What changes are proposed in this pull request?

Port PR #1486294 from universe to support Shift+select in the trace table. Manually porting to ship this in 3.9 (the PR has been there for a long forgotten so want to clean up:D)

How is this PR tested?

Existing unit/integration tests
New unit/integration tests
Manual tests

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release notes for MLflow users.

Support Shift+select in the Trace table.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

How should the PR be classified in the release notes? Choose one:

rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
rn/feature - A new user-facing feature worth mentioning in the release notes
rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?

Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
Bug fixes, doc updates and new features usually go into minor releases.
Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
Bug fixes and doc updates usually go into patch releases.

Yes (this PR will be cherry-picked and included in the next patch release)
No (this PR will be included in the next minor release)

github-actions · 2026-01-19T12:27:24Z

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20125/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20125/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20125/merge

github-actions · 2026-01-19T12:35:54Z

Documentation preview for 025f270 is available at:

https://pr-20125--mlflow-docs-preview.netlify.app/docs/latest/

More info

Ignore this comment if this PR does not change the documentation.
The preview is updated when a new commit is pushed to this PR.
This comment was created by this workflow run.
The documentation was built by this workflow run.

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBody.tsx

daniellok-db · 2026-01-20T04:38:18Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBody.tsx

+      if (!enableRowSelection) {
+        lastSelectedRowIdRef.current = null;
+        return;
+      }


hmm when is this case necessary? if row selection is disabled the user should have no way of selecting a row in the first place right

aside from this, looking at the code i'm not sure if enableRowSelection is ever false

daniellok-db · 2026-01-20T04:39:47Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBody.tsx

+      if (!rowSelection || Object.keys(rowSelection).length === 0) {
+        lastSelectedRowIdRef.current = null;
+      }


is it possible to handle this in the onclick handler instead when deselecting? we should avoid useEffects where possible to avoid unnecessary rerender cycles

makes sense, yeah it removes unnecessary rerender

daniellok-db · 2026-01-20T04:41:11Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBody.tsx

      },
    );

+    const getRowSelectionChangeHandler = useCallback(


do we need this to be a getter? why not just rowSelectionChangeHandler and return the function directly?

Hmm I quite not remember... this was sth I did when updated universe side a month ago😅 It seems removing it doesn't have an effect so we can simplify this.

daniellok-db · 2026-01-20T04:41:59Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBodyRows.tsx

  }) => {
    const cells = row.getVisibleCells();
    const intl = useIntl();
+    const rowSelectHandler = React.useMemo(


when https://github.com/mlflow/mlflow/pull/20125/files#r2706732804 is addressed this should be unnecessary, we can pass the prop directly to the select cell

daniellok-db

lgtm when comments addressed!

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

B-Step62 requested a review from daniellok-db January 19, 2026 12:27

B-Step62 added the v3.9.0 label Jan 19, 2026

github-actions bot added area/tracing MLflow Tracing and its integrations rn/feature Mention under Features in Changelogs. labels Jan 19, 2026

Support shift+select for Traces

2ee24db

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

B-Step62 force-pushed the support-shift-select-oss branch from 29878fb to 2ee24db Compare January 20, 2026 02:42

daniellok-db reviewed Jan 20, 2026

View reviewed changes

mlflow/server/js/src/shared/web-shared/genai-traces-table/GenAiTracesTableBody.tsx Outdated Show resolved Hide resolved

daniellok-db reviewed Jan 20, 2026

View reviewed changes

daniellok-db approved these changes Jan 20, 2026

View reviewed changes

github-actions bot assigned daniellok-db Jan 20, 2026

B-Step62 added 3 commits January 22, 2026 16:01

Merge branch 'master' into support-shift-select-oss

bb55c53

comment

6930ec1

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

fix test

025f270

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

B-Step62 added this pull request to the merge queue Jan 22, 2026

Merged via the queue into mlflow:master with commit c931ad6 Jan 22, 2026
48 checks passed

B-Step62 deleted the support-shift-select-oss branch January 22, 2026 22:56

harupy pushed a commit to harupy/mlflow that referenced this pull request Jan 28, 2026

Support shift+select for Traces (mlflow#20125)

bfc124d

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

harupy pushed a commit to harupy/mlflow that referenced this pull request Jan 28, 2026

Support shift+select for Traces (mlflow#20125)

318ad80

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

harupy pushed a commit that referenced this pull request Jan 28, 2026

Support shift+select for Traces (#20125)

168101e

Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support shift+select for Traces#20125

Support shift+select for Traces#20125
B-Step62 merged 4 commits intomlflow:masterfrom
B-Step62:support-shift-select-oss

B-Step62 commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Install mlflow from this PR

Uh oh!

github-actions bot commented Jan 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

daniellok-db Jan 20, 2026

Uh oh!

daniellok-db Jan 20, 2026 •

edited

Loading

Uh oh!

daniellok-db Jan 20, 2026

Uh oh!

B-Step62 Jan 22, 2026

Uh oh!

daniellok-db Jan 20, 2026

Uh oh!

B-Step62 Jan 22, 2026

Uh oh!

daniellok-db Jan 20, 2026

Uh oh!

daniellok-db left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

B-Step62 commented Jan 19, 2026

What changes are proposed in this pull request?

How is this PR tested?

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

What component(s), interfaces, languages, and integrations does this PR affect?

How should the PR be classified in the release notes? Choose one:

Should this PR be included in the next patch release?

Uh oh!

github-actions bot commented Jan 19, 2026

Install mlflow from this PR

Uh oh!

github-actions bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

daniellok-db Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

daniellok-db Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daniellok-db Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

B-Step62 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

daniellok-db Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

B-Step62 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

daniellok-db Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

daniellok-db left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jan 19, 2026 •

edited

Loading

daniellok-db Jan 20, 2026 •

edited

Loading