UI: Improve empty states for Traces and Sessions tabs#20034
UI: Improve empty states for Traces and Sessions tabs#20034daniellok-db merged 4 commits intomlflow:masterfrom
Conversation
🛠 DevTools 🛠
Install mlflow from this PRFor Databricks, use the following command: |
|
@ridgupta26 Thank you for the contribution! Could you fix the following issue(s)? ⚠ DCO checkThe DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details. ⚠ Invalid PR templateThis PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out. |
.vscode/settings.json
Outdated
| "python.testing.unittestEnabled": false, | ||
| "python.testing.pytestEnabled": true | ||
| "python.testing.pytestEnabled": true, | ||
| "cursorpyright.analysis.exclude": [ |
There was a problem hiding this comment.
do we need these changes?
There was a problem hiding this comment.
could you add some screenshots to the PR description? I think you will also have to use the PR template here: https://raw.githubusercontent.com/mlflow/mlflow/master/.github/pull_request_template.md
86c80db to
94957b4
Compare
|
Removed the VSCode settings changes - they were Cursor-specific settings that accidentally got included and are not needed for this PR. |
|
@danielseong1 made updates to the PR format as well as added the screenshots. |
|
Documentation preview for f75c551 is available at: More info
|
There was a problem hiding this comment.
@ridgupta26 Overall change looks good, can you fix linter failures?
You can run yarn prettier:check at mlflow/server/js to run JS formatter, and then run pre-commit run --all-files for general linters.
(btw plz ignore "MLflow tests" CI failures, they are transient package download issues)
82ab80f to
ce65d6f
Compare
- Center Traces empty state layout to match Sessions tab - Update Traces heading to 'Log traces to this experiment' with primary color and center alignment - Constrain all content to 600px max width for consistency - Add secondary color to all text paragraphs - Fix code snippet theme switching for dark mode (use 'duotoneDark') - Remove custom style overrides, use design system defaults - Hide column headers in Sessions table when empty - Ensure code blocks properly constrain to 600px in both tabs Signed-off-by: ridgupta26 <ridhima.gatech@gmail.com>
- Use text-primary color for Sessions empty state heading to match Traces tab - Replace hardcoded grey100 border with design system borderDecorative token in TracesV3Toolbar Signed-off-by: ridgupta26 <ridhima.gatech@gmail.com>
Signed-off-by: ridgupta26 <ridhima.gatech@gmail.com>
ce65d6f to
d8610a6
Compare
|
Fixed DCO issue by rebasing the branch onto the latest master and cherry-picking only the commits that belong to this PR. All checks are now passing! ✅ |
...rver/js/src/experiment-tracking/components/traces/quickstart/TraceTableGenericQuickstart.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: ridgupta26 <ridhima.gatech@gmail.com> Signed-off-by: Daniel Lok <daniel.lok@databricks.com> Co-authored-by: ridgupta26 <ridhima.gatech@gmail.com> Co-authored-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: ridgupta26 <ridhima.gatech@gmail.com> Signed-off-by: Daniel Lok <daniel.lok@databricks.com> Co-authored-by: ridgupta26 <ridhima.gatech@gmail.com> Co-authored-by: Daniel Lok <daniel.lok@databricks.com>
Before
emptys-states-part1-before.mp4
After
emptys-states-part1-after.mp4
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
This PR improves the UI consistency and readability of empty states in the Traces and Sessions tabs:
How is this PR tested?
Manual testing:
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Improved the visual consistency and readability of empty states in the Traces and Sessions tabs with proper centering, width constraints, updated heading text, correct design system colors, and fixed dark mode theming for code snippets.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.