[Online Scoring][6.1/x] Add IS NULL / IS NOT NULL comparator support for trace metadata filtering#19720
Merged
dbczumar merged 114 commits intomlflow:masterfrom Jan 9, 2026
Merged
Conversation
This was referenced Jan 1, 2026
Merged
9ca727f to
682f9b5
Compare
Add SCORER_BACKEND_TRACKING and SCORER_BACKEND_DATABRICKS constants to replace hardcoded string literals throughout the codebase. Signed-off-by: dbczumar <corey.zumar@databricks.com>
- Add inline comments clarifying that each scorer has at most one online configuration, as guaranteed by the server - Use set comprehension in list_scorer_versions to eliminate duplicate scorer_ids before querying online configs Signed-off-by: dbczumar <corey.zumar@databricks.com>
Add infrastructure utilities for online scoring of traces: - OnlineScorerSampler: Handles sampling logic for scorers - OnlineTraceCheckpointManager: Tracks last processed trace - OnlineTraceLoader: Fetches traces from tracking store - Constants for online scoring configuration - Environment variable for max workers - Assessment metadata key for session ID Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
…n scoring Signed-off-by: dbczumar <corey.zumar@databricks.com>
- Remove ONLINE_SCORING_SESSION_ID constant (added to PR 8 where needed) - Restore job.py to PR 5 state (run_online_trace_scorer_job belongs in PR 6c) - Fix entities.py class ordering (OnlineScoringConfig first) Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Use 'not supported' instead of 'cannot apply' and 'currently only supported' instead of 'only work' for more formal/professional tone. Signed-off-by: dbczumar <corey.zumar@databricks.com>
…scorers_by_filter Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
- Add inline comments to OnlineTraceScoringCheckpoint fields explaining timestamp_ms and trace_id (used as tie breaker for same timestamp) - Fix OnlineScorer import to use online.entities instead of online.processor Signed-off-by: dbczumar <corey.zumar@databricks.com>
Access sample_rate and filter_string through online_config property instead of directly on OnlineScorer entity. Signed-off-by: dbczumar <corey.zumar@databricks.com>
Update make_online_scorer helper to create OnlineScorer with online_config property containing OnlineScoringConfig entity. Signed-off-by: dbczumar <corey.zumar@databricks.com>
Replace manual key existence check with defaultdict(list) to simplify the grouping logic. Signed-off-by: dbczumar <corey.zumar@databricks.com>
Add IS NULL comparator support to search_utils for trace metadata filtering, enabling queries to filter traces where specific metadata fields are not set. Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
The second handler for IS NOT NULL (checking for separate NOT and NULL tokens) is unreachable with sqlparse >= 0.5.3, which always parses "NOT NULL" as a single keyword token. Testing confirms this pattern holds across various whitespace configurations. Signed-off-by: dbczumar <corey.zumar@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Support filtering traces based on whether a particular piece of metadata is null or not null.
not nullfiltering is required for online scoring, since evaluation runs need to be excluded.How is this PR tested?
Does this PR require documentation update?
Release Notes
search_traces() now supports is null / is not null filtering for trace metadata
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.