Skip to content

Skip registering sqlalchemy store when sqlalchemy lib is not installed#19563

Merged
WeichenXu123 merged 5 commits intomlflow:masterfrom
WeichenXu123:skip-sqlalchemy-in-databricks
Dec 26, 2025
Merged

Skip registering sqlalchemy store when sqlalchemy lib is not installed#19563
WeichenXu123 merged 5 commits intomlflow:masterfrom
WeichenXu123:skip-sqlalchemy-in-databricks

Conversation

@WeichenXu123
Copy link
Collaborator

@WeichenXu123 WeichenXu123 commented Dec 22, 2025 •
edited by github-actions bot
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19563/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19563/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19563/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Skip registering sqlalchemy store when sqlalchemy lib is not installed

sqlalchemy is not a requirement for mlflow-skinny , and in databricks runtime, sqlalchemy is not preinstalled.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@WeichenXu123
init
3015b4d 
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Copilot AI review requested due to automatic review settings December 22, 2025 11:51
@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs. labels Dec 22, 2025
@WeichenXu123 WeichenXu123 added v3.8.1 and removed rn/bug-fix Mention under Bug Fixes in Changelogs. area/tracking Tracking service, tracking client APIs, autologging labels Dec 22, 2025
Copilot AI reviewed Dec 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds conditional registration of SQLAlchemy stores based on whether the sqlalchemy library is installed. This is necessary because sqlalchemy is not a requirement for mlflow-skinny and is not pre-installed in Databricks runtime environments.

Key changes:

  • Added import checks for sqlalchemy before registering database engine schemes
  • Applied the same pattern in both tracking service and model registry utilities

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
mlflow/tracking/_tracking_service/utils.py Added conditional check for sqlalchemy availability before registering database engine schemes in tracking store registry
mlflow/tracking/_model_registry/utils.py Added conditional check for sqlalchemy availability before registering database engine schemes in model registry store registry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025 •
edited
Loading

Documentation preview for 77df71d is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@WeichenXu123 WeichenXu123 added the team-review Trigger a team review request label Dec 23, 2025
@WeichenXu123 WeichenXu123 added the rn/bug-fix Mention under Bug Fixes in Changelogs. label Dec 23, 2025
TomeHirata
TomeHirata reviewed Dec 23, 2025
View reviewed changes
@TomeHirata
Copy link
Collaborator

TomeHirata commented Dec 23, 2025

What's the context of this change? Did users see any exception when using mlflow-skinny in Databricks?

TomeHirata
TomeHirata approved these changes Dec 24, 2025
View reviewed changes
Copy link
Collaborator

@TomeHirata TomeHirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, can you add skinny-test?

@WeichenXu123
Copy link
Collaborator Author

WeichenXu123 commented Dec 26, 2025

What's the context of this change? Did users see any exception when using mlflow-skinny in Databricks?

Yes.

@WeichenXu123
update
d42a320 
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123
test
0aa74fc 
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123
update test
7fd0f48 
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123
update test
77df71d 
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123 WeichenXu123 added this pull request to the merge queue Dec 26, 2025
Merged via the queue into mlflow:master with commit 98d8ea9 Dec 26, 2025
46 checks passed
@WeichenXu123 WeichenXu123 deleted the skip-sqlalchemy-in-databricks branch December 26, 2025 10:07
WeichenXu123 added a commit to WeichenXu123/mlflow that referenced this pull request Dec 26, 2025
@WeichenXu123
Skip registering sqlalchemy store when sqlalchemy lib is not installed (
cd5049f 
mlflow#19563)

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
WeichenXu123 added a commit that referenced this pull request Dec 26, 2025
@WeichenXu123
Skip registering sqlalchemy store when sqlalchemy lib is not installed (
2007698 
#19563)

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
omarfarhoud pushed a commit to omarfarhoud/mlflow that referenced this pull request Jan 20, 2026
@WeichenXu123 @omarfarhoud
Skip registering sqlalchemy store when sqlalchemy lib is not installed (
8280226 
mlflow#19563)

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@TomeHirata TomeHirata TomeHirata approved these changes

@harupy harupy Awaiting requested review from harupy

Assignees

@TomeHirata TomeHirata

Labels

rn/bug-fix Mention under Bug Fixes in Changelogs. team-review Trigger a team review request v3.8.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WeichenXu123 @TomeHirata