Skip to content

[ Gateway 9/10 ] Add the Endpoint Edit Page#19502

Merged
BenWilson2 merged 1 commit intomlflow:masterfrom
BenWilson2:stack/gateway-ui/endpoint-edit
Dec 26, 2025
Merged

[ Gateway 9/10 ] Add the Endpoint Edit Page#19502
BenWilson2 merged 1 commit intomlflow:masterfrom
BenWilson2:stack/gateway-ui/endpoint-edit

Conversation

@BenWilson2
Copy link
Member

@BenWilson2 BenWilson2 commented Dec 19, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Adds the endpoint edit page and links the the edit button on the listing page to the given endpoint's edit page.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests
Screenshot 2025-12-19 at 7 29 39 PM

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an endpoint edit page for the AI Gateway feature, allowing users to modify endpoint configurations including name, provider, model, and authentication details. The implementation follows a stacked PR approach and builds on previous Gateway UI work.

Key Changes:

  • Adds endpoint edit page with form handling and validation
  • Extends provider models with new capability fields (supports_response_schema, deprecation_date)
  • Implements comprehensive hooks for data fetching and mutations
  • Adds utility functions for formatting, error handling, and date conversion
  • Includes extensive test coverage for hooks and utilities

Reviewed changes

Copilot reviewed 112 out of 115 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mlflow/utils/providers.py Adds model capability fields (supports_response_schema, deprecation_date)
mlflow/server/js/src/lang/default/en.json Adds 100+ internationalization strings for UI
mlflow/server/js/src/gateway/utils/*.ts Utility functions for providers, secrets, errors, dates, and formatters
mlflow/server/js/src/gateway/types.ts Updates type definitions for secrets, bindings, and resource types
mlflow/server/js/src/gateway/routes.ts Adds edit endpoint route configuration
mlflow/server/js/src/gateway/hooks/*.ts Data fetching and mutation hooks with comprehensive tests
mlflow/server/js/src/gateway/pages/*.tsx Page components for edit, create, and API keys
mlflow/server/js/src/gateway/components/* Reusable components for secrets, models, endpoints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

Documentation preview for 21adcb4 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@BenWilson2 BenWilson2 force-pushed the stack/gateway-ui/endpoint-edit branch 7 times, most recently from 7789a9b to 41ea2b9 Compare December 23, 2025 22:10
@@ -0,0 +1,2 @@
export { EditEndpointFormRenderer } from './EditEndpointFormRenderer';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this file

@@ -0,0 +1,2 @@
export { ModelDefinitionConfigSection } from './ModelDefinitionConfigSection';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Collaborator

@TomeHirata TomeHirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@BenWilson2 BenWilson2 force-pushed the stack/gateway-ui/endpoint-edit branch from 41ea2b9 to 966419e Compare December 26, 2025 17:25
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
@BenWilson2 BenWilson2 force-pushed the stack/gateway-ui/endpoint-edit branch from 966419e to 21adcb4 Compare December 26, 2025 18:54
@BenWilson2 BenWilson2 added this pull request to the merge queue Dec 26, 2025
Merged via the queue into mlflow:master with commit 79c6504 Dec 26, 2025
53 checks passed
@BenWilson2 BenWilson2 deleted the stack/gateway-ui/endpoint-edit branch December 26, 2025 19:25
omarfarhoud pushed a commit to omarfarhoud/mlflow that referenced this pull request Jan 20, 2026
Signed-off-by: Ben Wilson <benjamin.wilson@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/feature Mention under Features in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants