Fix MultiIndex column search crash in dataset schema table#19461
Merged
Fix MultiIndex column search crash in dataset schema table#19461
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Handle both string and array column names in the search filter - Join array names with '.' for display and searching - Tested with MultiIndex pandas datasets Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
- Test rendering of regular and MultiIndex column names - Test filtering by first and second levels of MultiIndex - Test filtering by column type - Test case-insensitive filtering - Test "No results" message All 8 tests passing Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
hubertzub-db
approved these changes
Dec 17, 2025
- Remove unused userEvent import from test file - Add SchemaColumn interface for better type safety - Replace any[] type with SchemaColumn[] in component props Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix searching in pandas dataset with MultiIndex column
Fix MultiIndex column search crash in dataset schema table
Dec 17, 2025
harupy
approved these changes
Dec 17, 2025
Member
|
/autoformat |
Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>
Contributor
|
Documentation preview for dabc0c4 is available at: More info
|
joelrobin18
approved these changes
Dec 17, 2025
harupy
reviewed
Dec 17, 2025
...ent-tracking/components/experiment-page/components/runs/ExperimentViewDatasetSchemaTable.tsx
Outdated
Show resolved
Hide resolved
harupy
reviewed
Dec 17, 2025
...ent-tracking/components/experiment-page/components/runs/ExperimentViewDatasetSchemaTable.tsx
Outdated
Show resolved
Hide resolved
hubertzub-db
approved these changes
Dec 18, 2025
Collaborator
hubertzub-db
left a comment
There was a problem hiding this comment.
lg with a question
...ent-tracking/components/experiment-page/components/runs/ExperimentViewDatasetSchemaTable.tsx
Outdated
Show resolved
Hide resolved
- Replace with inline type in ExperimentViewDatasetSchemaTableProps - Remove unnecessary type annotations from filter and map callbacks - Interface was only used internally, no need to export Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Member
|
@copilot update the pr description |
Contributor
Author
Updated the PR description to accurately reflect the final implementation, including:
|
WeichenXu123
pushed a commit
to WeichenXu123/mlflow
that referenced
this pull request
Dec 19, 2025
) Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Co-authored-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>
WeichenXu123
pushed a commit
that referenced
this pull request
Dec 19, 2025
Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Co-authored-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Fixes #19460
What changes are proposed in this pull request?
Searching in the dataset schema table threw
TypeError: s.toLowerCase is not a functionwhen the dataset had pandas MultiIndex columns. MultiIndex column names are stored as arrays (e.g.,["foo", "a"]) rather than strings, causing the search filter to calltoLowerCase()on arrays.Changes:
hasFilterfunction to handle both string and array column names["foo", "a"]→"foo.a")Example:
Before (crashed):
Screen.Recording.2025-12-18.at.17.10.57.mov
After (works):
Searching for "foo" filters to foo.a and foo.b:

Searching for "bar" filters to bar.c and bar.d:

Regular datasets continue to work as expected:

How is this PR tested?
Tests added:
ExperimentViewDatasetSchemaTablecomponentDoes this PR require documentation update?
Release Notes
Is this a user-facing change?
Fixed crash when searching dataset schema with pandas MultiIndex columns. Search now correctly handles hierarchical column names.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.