Skip to content

Fix not escaping backticks in search_traces#19418

Merged
daniellok-db merged 4 commits intomlflow:masterfrom
daniellok-db:daniellok-db/fix-traces-search
Dec 16, 2025
Merged

Fix not escaping backticks in search_traces#19418
daniellok-db merged 4 commits intomlflow:masterfrom
daniellok-db:daniellok-db/fix-traces-search

Conversation

@daniellok-db
Copy link
Collaborator

@daniellok-db daniellok-db commented Dec 16, 2025 •
edited
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19418/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19418/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19418/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Discovered this when debugging something unrelated. The backend currently does not escape backticks, so when the UI sends a filter like span.attributes.\mlflow.spanInputs``, we retrieve no spans.

This PR modifies the filter generation to strip backticks on attribute names.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Before:

Screen.Recording.2025-12-16.at.11.35.41.AM.mov

After:

Screen.Recording.2025-12-16.at.11.34.53.AM.mov

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@daniellok-db
fix
86984b6 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
@daniellok-db
fix
486bc23 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Copilot AI review requested due to automatic review settings December 16, 2025 03:36
@daniellok-db daniellok-db added the team-review Trigger a team review request label Dec 16, 2025
@github-actions github-actions bot added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. labels Dec 16, 2025
Copilot AI reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the traces search functionality where the search API fails to fetch spans when the mlflow.spanInputs attribute is enclosed in backticks. The fix removes the backticks from the filter query construction.

  • Removed backticks from mlflow.spanInputs in the search filter to match the backend API's expected format
  • Updated corresponding tests to reflect the corrected filter syntax

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useMlflowTraces.tsx Fixed the filter query construction by removing backticks from span.attributes.mlflow.spanInputs
mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useMlflowTraces.test.tsx Updated test assertions to match the corrected filter syntax without backticks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

Documentation preview for 5865a76 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

TomeHirata
TomeHirata reviewed Dec 16, 2025
View reviewed changes
mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useMlflowTraces.test.tsx
// Verify the search query was sent to the backend
const [url, { body }] = jest.mocked(fetchFn).mock.lastCall as any;
expect(url).toEqual('/ajax-api/3.0/mlflow/traces/search');
expect(JSON.parse(body).filter).toContain("span.attributes.`mlflow.spanInputs` ILIKE '%test query%'");
Copy link
Collaborator

@TomeHirata TomeHirata Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure when it was changed, but I remember we previously supported this syntax with backticks. I wonder if we should add back the syntax.

@daniellok-db
fix backend instead
7f28041 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
@daniellok-db
revert
5865a76 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
harupy
harupy approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harupy
Copy link
Member

harupy commented Dec 16, 2025

let's update the pr title and description

@daniellok-db daniellok-db changed the title Fix traces search in frontend Fix not escaping backticks in search_traces Dec 16, 2025
@daniellok-db daniellok-db added this pull request to the merge queue Dec 16, 2025
Merged via the queue into mlflow:master with commit 397a55f Dec 16, 2025
54 checks passed
@daniellok-db daniellok-db deleted the daniellok-db/fix-traces-search branch December 16, 2025 07:14
WeichenXu123 pushed a commit to WeichenXu123/mlflow that referenced this pull request Dec 19, 2025
@daniellok-db @WeichenXu123
Fix not escaping backticks in search_traces (mlflow#19418)
0c52d71 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
WeichenXu123 pushed a commit that referenced this pull request Dec 19, 2025
@daniellok-db @WeichenXu123
Fix not escaping backticks in search_traces (#19418)
b93629a 
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@harupy harupy harupy approved these changes

@TomeHirata TomeHirata TomeHirata approved these changes

@B-Step62 B-Step62 Awaiting requested review from B-Step62

@BenWilson2 BenWilson2 Awaiting requested review from BenWilson2

@kevin-lyn kevin-lyn Awaiting requested review from kevin-lyn

@serena-ruan serena-ruan Awaiting requested review from serena-ruan

@WeichenXu123 WeichenXu123 Awaiting requested review from WeichenXu123

@xq-yin xq-yin Awaiting requested review from xq-yin

Assignees

@harupy harupy

@TomeHirata TomeHirata

Labels

area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. team-review Trigger a team review request v3.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daniellok-db @harupy @TomeHirata