Add autouse fixture to clear SQLAlchemy engine map between tests#19402
Merged
harupy merged 2 commits intomlflow:masterfrom Dec 16, 2025
Merged
Add autouse fixture to clear SQLAlchemy engine map between tests#19402harupy merged 2 commits intomlflow:masterfrom
harupy merged 2 commits intomlflow:masterfrom
Conversation
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an autouse fixture to clear the SQLAlchemy engine map between tests to prevent test pollution from cached database connections.
Key Changes
- Adds a new
clear_engine_map()autouse fixture that clearsSqlAlchemyStore._db_uri_sql_alchemy_engine_mapto prevent engine caching across tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WeichenXu123
pushed a commit
to WeichenXu123/mlflow
that referenced
this pull request
Dec 19, 2025
…low#19402) Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
N/A
What changes are proposed in this pull request?
Add an
autousefixture that clearsSqlAlchemyStore._db_uri_sql_alchemy_engine_mapbetween tests to prevent test pollution from cached SQLAlchemy engine connections.This fixes the following error where a cached engine points to a temporary database file that no longer exists:
https://github.com/mlflow/mlflow/actions/runs/20225403229/job/58055633634
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/build: Build and test infrastructure for MLflowHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionShould this PR be included in the next patch release?
🤖 Generated with Claude Code