[UserFrustration] Add coloring for UserFrustration eval results in the eval run tab by xsh310 · Pull Request #19383 · mlflow/mlflow

xsh310 · 2025-12-15T01:32:34Z

🥞 Stacked PR

Use this link to review incremental changes.

stack/user-frustration-eval-run-tab-ui-polish [Files changed]

What changes are proposed in this pull request?

Context

One feedback from the multi-turn M1 bug bash was that the UI for UserFrustration judge is not highlighted and difficult to read (ML-60165).

This PR

Add coloring for UserFrustration built-in judge results in the eval run tab and trace tab so that the result is highlighted and easier to read.

How is this PR tested?

Existing unit/integration tests
New unit/integration tests
Manual tests

Manual Test

Before	After

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

How should the PR be classified in the release notes? Choose one:

rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
rn/feature - A new user-facing feature worth mentioning in the release notes
rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?

Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
Bug fixes, doc updates and new features usually go into minor releases.
Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
Bug fixes and doc updates usually go into patch releases.

Yes (this PR will be cherry-picked and included in the next patch release)
No (this PR will be included in the next minor release)

xsh310 · 2025-12-15T04:24:03Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/utils/Colors.ts

 const ERROR_BARCHART_BAR_COLOR = '#f09065';

 const TAG_PASS_COLOR = '#02B30214'; // From tagBackgroundLime.
+const TAG_WARNING_COLOR = '#FCEACA';


I'm using the yellow200 for this

any reason not to use theme.colors.yellow200 directly? i see the other props use a function like (theme: ThemeType) => ...

also does this look good in dark mode? if not then let's definitely use the same pattern as the other color getters and define a separate dark mode color

xsh310 · 2025-12-15T04:24:26Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/utils/Colors.ts

 export const COMPARE_TO_RUN_COLOR = '#FFAB00';

 const PASS_BARCHART_BAR_COLOR = '#99DDB4';
+const WARNING_BARCHART_BAR_COLOR = '#F7C58A';


Let me know if there's a recommended color value for this

can we use theme colors instead?

xsh310 · 2025-12-15T04:27:01Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/utils/Colors.ts

+  icon?: string;
+  text?: string;
+} | undefined => {
+  const builtInAssessment = BUILTIN_SCORER_ASSESSMENT_COLORS[assessmentInfo.name as BuiltInScorerAssessmentName];


I'm currently checking with assessmentInfo.name which means this change won't work if user provides a custom name to the UserFrustration scorer. From what I'm seeing our, we don't have the scorer class information rn at this level and we might need some protocol change to acquire this information. I will explore that in a separate PR.

i think this is fine - users probably only change the name if they are customizing the instructions as well

github-actions · 2025-12-15T04:39:53Z

Documentation preview for ee2a55e is available at:

https://pr-19383--mlflow-docs-preview.netlify.app/docs/latest/

More info

Ignore this comment if this PR does not change the documentation.
The preview is updated when a new commit is pushed to this PR.
This comment was created by this workflow run.
The documentation was built by this workflow run.

smoorjani

Love this! would block on Dan/Daniel for UI review, but end result looks great!

mlflow/server/js/src/shared/web-shared/genai-traces-table/utils/Colors.ts

danielseong1 · 2025-12-15T22:31:01Z

mlflow/server/js/src/shared/web-shared/genai-traces-table/utils/Colors.ts

+      text?: string;
+    }
+  | undefined => {
+  const builtInAssessment = BUILTIN_SCORER_ASSESSMENT_COLORS[assessmentInfo.name as BuiltInScorerAssessmentName];


we probably shouldn't have this as BuiltInScorerAssessmentName since we don't have all built in assessment names in the map. just having string here should be fine

xsh310 · 2025-12-16T00:55:08Z

Updated PR to address @danielseong1 's comments

daniellok-db

lg after https://github.com/mlflow/mlflow/pull/19383/files#r2621704251 is addressed

… the eval run tab Signed-off-by: Xiang Shen <xshen.shc@gmail.com>

xsh310 · 2025-12-16T05:26:43Z

Updated to PR to address @daniellok-db 's comment. Verified that dark mode with orange now looks good

…e eval run tab (mlflow#19383) Signed-off-by: Xiang Shen <xshen.shc@gmail.com>

…e eval run tab (#19383) Signed-off-by: Xiang Shen <xshen.shc@gmail.com>

xsh310 mentioned this pull request Dec 15, 2025

[UserFrustration] Update user frustration built in judge output name #19382

Merged

29 tasks

xsh310 force-pushed the stack/user-frustration-eval-run-tab-ui-polish branch from 47a55bc to 859f562 Compare December 15, 2025 03:55

xsh310 mentioned this pull request Dec 15, 2025

[UserFrustration] Add coloring for UserFrustration eval results in the AssessmentDisplayValue component #19388

Merged

29 tasks

xsh310 changed the title ~~[MultiTurn][BuiltIn] Add coloring for UserFrustration eval results in the eval run tab~~ [UserFrustration] Add coloring for UserFrustration eval results in the eval run tab Dec 15, 2025

xsh310 commented Dec 15, 2025

View reviewed changes

xsh310 requested review from AveshCSingh, B-Step62, alkispoly-db, danielseong1, dbczumar and smoorjani and removed request for AveshCSingh and smoorjani December 15, 2025 04:29

xsh310 marked this pull request as ready for review December 15, 2025 04:30

github-actions bot added area/evaluation MLflow Evaluation area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. labels Dec 15, 2025

xsh310 force-pushed the stack/user-frustration-eval-run-tab-ui-polish branch from 859f562 to 96b51f1 Compare December 15, 2025 17:24

smoorjani approved these changes Dec 15, 2025

View reviewed changes

danielseong1 reviewed Dec 15, 2025

View reviewed changes

mlflow/server/js/src/shared/web-shared/genai-traces-table/utils/Colors.ts Show resolved Hide resolved

danielseong1 reviewed Dec 15, 2025

View reviewed changes

danielseong1 approved these changes Dec 15, 2025

View reviewed changes

xsh310 force-pushed the stack/user-frustration-eval-run-tab-ui-polish branch 3 times, most recently from a612e8b to a653e6a Compare December 16, 2025 00:48

xsh310 force-pushed the stack/user-frustration-eval-run-tab-ui-polish branch from a653e6a to 84e5f73 Compare December 16, 2025 02:41

xsh310 enabled auto-merge December 16, 2025 02:42

xsh310 disabled auto-merge December 16, 2025 03:02

xsh310 requested a review from daniellok-db December 16, 2025 04:10

daniellok-db approved these changes Dec 16, 2025

View reviewed changes

[MultiTurn][BuiltIn] Add coloring for UserFrustration eval results in…

ee2a55e

… the eval run tab Signed-off-by: Xiang Shen <xshen.shc@gmail.com>

xsh310 force-pushed the stack/user-frustration-eval-run-tab-ui-polish branch from 84e5f73 to ee2a55e Compare December 16, 2025 05:24

xsh310 added the v3.8.0 label Dec 16, 2025

xsh310 enabled auto-merge December 16, 2025 05:27

xsh310 added this pull request to the merge queue Dec 16, 2025

Merged via the queue into mlflow:master with commit ea009cf Dec 16, 2025
58 checks passed

xsh310 deleted the stack/user-frustration-eval-run-tab-ui-polish branch December 16, 2025 06:04

WeichenXu123 pushed a commit to WeichenXu123/mlflow that referenced this pull request Dec 19, 2025

[UserFrustration] Add coloring for UserFrustration eval results in th…

0427ff9

…e eval run tab (mlflow#19383) Signed-off-by: Xiang Shen <xshen.shc@gmail.com>

WeichenXu123 pushed a commit that referenced this pull request Dec 19, 2025

[UserFrustration] Add coloring for UserFrustration eval results in th…

4d978f0

…e eval run tab (#19383) Signed-off-by: Xiang Shen <xshen.shc@gmail.com>

Conversation

xsh310 commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🥞 Stacked PR

What changes are proposed in this pull request?

Context

This PR

How is this PR tested?

Manual Test

Does this PR require documentation update?

Release Notes

Is this a user-facing change?

What component(s), interfaces, languages, and integrations does this PR affect?

How should the PR be classified in the release notes? Choose one:

Should this PR be included in the next patch release?

Uh oh!

xsh310 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

daniellok-db Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

daniellok-db Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xsh310 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

danielseong1 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

xsh310 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielseong1 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smoorjani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

danielseong1 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

xsh310 commented Dec 16, 2025

Uh oh!

daniellok-db left a comment

Choose a reason for hiding this comment

Uh oh!

xsh310 commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xsh310 commented Dec 15, 2025 •

edited

Loading

daniellok-db Dec 16, 2025 •

edited

Loading

xsh310 Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading