Skip to content

AgentServer: add proxy helper#19323

Merged
serena-ruan merged 8 commits intomlflow:masterfrom
bbqiu:bbqiu/agent-server-proxy
Dec 15, 2025
Merged

AgentServer: add proxy helper#19323
serena-ruan merged 8 commits intomlflow:masterfrom
bbqiu:bbqiu/agent-server-proxy

Conversation

@bbqiu
Copy link
Collaborator

@bbqiu bbqiu commented Dec 11, 2025 •
edited by github-actions bot
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19323/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19323/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19323/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@bbqiu
.
507955c 
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@github-actions github-actions bot added v3.7.1 area/scoring MLflow Model server, model deployment tools, Spark UDFs rn/none List under Small Changes in Changelogs. labels Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025 •
edited
Loading

Documentation preview for 9c5c807 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

bbqiu added 2 commits December 10, 2025 17:33
@bbqiu
.
a8802b7 
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu
.
f2efe02 
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu bbqiu requested a review from serena-ruan December 11, 2025 03:29
serena-ruan
serena-ruan reviewed Dec 11, 2025
View reviewed changes
@serena-ruan
Copy link
Collaborator

serena-ruan commented Dec 11, 2025 •
edited by github-actions bot
Loading

/review

🚀 Review workflow started

✅ Review completed.

Review Output

Review Complete

I've reviewed PR #19323 "AgentServer: add proxy helper" and found 3 style guide violations in the test file:

Issues Found:

  1. tests/genai/test_agent_server.py:571 - Missing mock assertion in test_chat_proxy_forwards_unmatched_requests(). The mock needs assert_called_once() to verify it was invoked correctly.

  2. tests/genai/test_agent_server.py:602 - Redundant lazy import of httpx in test_chat_proxy_handles_connect_error(). Since httpx is already imported at the top of the server.py file, this local import is unnecessary and violates MLflow's "use top-level imports" principle.

  3. tests/genai/test_agent_server.py:660 - Weak assertion in test_chat_proxy_respects_chat_app_port_env_var(). The test should verify the mock was called once and should directly compare the full URL string instead of using in str().

The main implementation in server.py looks good - no style guide violations or bugs detected there. All review comments have been posted to the PR.

github-actions[bot]
github-actions bot reviewed Dec 11, 2025
View reviewed changes
github-actions[bot]
github-actions bot reviewed Dec 11, 2025
View reviewed changes
github-actions[bot]
github-actions bot reviewed Dec 11, 2025
View reviewed changes
@bbqiu
.
8632782 
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu bbqiu requested a review from serena-ruan December 11, 2025 04:03
serena-ruan
serena-ruan approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bbqiu added 3 commits December 11, 2025 08:54
@bbqiu
.
acff69f 
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu
.
299d6c0 
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@bbqiu
.
c0d04db 
Signed-off-by: bbqiu <bryan.qiu@databricks.com>
@harupy harupy added v3.8.0 and removed v3.7.1 labels Dec 13, 2025
@serena-ruan serena-ruan added this pull request to the merge queue Dec 15, 2025
Merged via the queue into mlflow:master with commit 9169bd7 Dec 15, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@serena-ruan serena-ruan serena-ruan approved these changes

Assignees

@serena-ruan serena-ruan

Labels

area/scoring MLflow Model server, model deployment tools, Spark UDFs rn/none List under Small Changes in Changelogs. v3.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbqiu @serena-ruan @harupy