Skip to content

Adjust the dual exporter logic for tracing#19320

Merged
kriscon-db merged 8 commits intomlflow:masterfrom
kriscon-db:dual-export-fix
Dec 11, 2025
Merged

Adjust the dual exporter logic for tracing#19320
kriscon-db merged 8 commits intomlflow:masterfrom
kriscon-db:dual-export-fix

Conversation

@kriscon-db
Copy link
Collaborator

@kriscon-db kriscon-db commented Dec 10, 2025 •
edited
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19320/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19320/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19320/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Change tracing precedence order to allow for dual exporting even if set_destination is called.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

@kriscon-db Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@kriscon-db
Copy link
Collaborator Author

kriscon-db commented Dec 10, 2025

/autoformat

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025 •
edited
Loading

Documentation preview for fd8369c is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@github-actions github-actions bot added area/tracing MLflow Tracing and its integrations rn/none List under Small Changes in Changelogs. labels Dec 10, 2025
@kriscon-db
Copy link
Collaborator Author

kriscon-db commented Dec 10, 2025

/autoformat

B-Step62
B-Step62 approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion

mlflow/tracing/provider.py Outdated
# If dual export is set AND we have already added a set_destination processor, return.
# If dual export is set but no set_destination processor added, skip return and go
# to default processing to catch the default processor, if present.
if (not MLFLOW_TRACE_ENABLE_OTLP_DUAL_EXPORT.get()) or added_destination_processor:
Copy link
Collaborator

@B-Step62 B-Step62 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check the processors list has non-otlp one, rather than introducing a new flag? We may add another precedence processor other than destination.

Copy link
Collaborator Author

@kriscon-db kriscon-db Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

edwinhe-db
edwinhe-db reviewed Dec 11, 2025
View reviewed changes
mlflow/tracing/provider.py
if (not MLFLOW_TRACE_ENABLE_OTLP_DUAL_EXPORT.get()) or added_destination_processor:
return processors

# Finally, default MLflow-based processors (inference table in serving, else tracking URI).
Copy link
Collaborator

@edwinhe-db edwinhe-db Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure that users can not configure both trace destination processor AND inference table/default mlflow processor in the below code block

Copy link
Collaborator Author

@kriscon-db kriscon-db Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If trace destination is set, then the only way to not return is to pass the OLTP and dual export check which would force a return in the 2nd block. I don't believe this is a possible outcome with the current logic.

@kriscon-db
Copy link
Collaborator Author

kriscon-db commented Dec 11, 2025

/autoformat

serena-ruan
serena-ruan reviewed Dec 11, 2025
View reviewed changes
@kriscon-db
Copy link
Collaborator Author

kriscon-db commented Dec 11, 2025

/autoformat

serena-ruan
serena-ruan reviewed Dec 11, 2025
View reviewed changes
serena-ruan
serena-ruan reviewed Dec 11, 2025
View reviewed changes
@kriscon-db
Copy link
Collaborator Author

kriscon-db commented Dec 11, 2025

/autoformat

serena-ruan
serena-ruan approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kriscon-db
Copy link
Collaborator Author

kriscon-db commented Dec 11, 2025

/autoformat

@mlflow-app
Autoformat: https://github.com/mlflow/mlflow/actions/runs/20134379569
fd8369c 
Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>
@kriscon-db kriscon-db added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@kriscon-db kriscon-db added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@kriscon-db kriscon-db added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@kriscon-db kriscon-db added this pull request to the merge queue Dec 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2025
@kriscon-db @mlflow-app
Adjust the dual exporter logic for tracing (#19320)
667e2a4 
Signed-off-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>
Co-authored-by: mlflow-app[bot] <mlflow-app[bot]@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@kriscon-db kriscon-db added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@kriscon-db kriscon-db added this pull request to the merge queue Dec 11, 2025
Merged via the queue into mlflow:master with commit b45c551 Dec 11, 2025
71 of 74 checks passed
@kriscon-db kriscon-db deleted the dual-export-fix branch December 11, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edwinhe-db edwinhe-db edwinhe-db left review comments

@B-Step62 B-Step62 B-Step62 approved these changes

@serena-ruan serena-ruan serena-ruan approved these changes

@ian-ack-db ian-ack-db Awaiting requested review from ian-ack-db

Assignees

@B-Step62 B-Step62

@serena-ruan serena-ruan

Labels

area/tracing MLflow Tracing and its integrations rn/none List under Small Changes in Changelogs. v3.7.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kriscon-db @B-Step62 @serena-ruan @edwinhe-db