Skip to content

[ML-59817] Address double scorer call events for wrapped builtin scorers#19288

Merged
xsh310 merged 1 commit intomlflow:masterfrom
xsh310:stack/ML-59817-address-double-call-events-for-wrapped-builtin-scorers
Dec 12, 2025
Merged

[ML-59817] Address double scorer call events for wrapped builtin scorers#19288
xsh310 merged 1 commit intomlflow:masterfrom
xsh310:stack/ML-59817-address-double-call-events-for-wrapped-builtin-scorers

Conversation

@xsh310
Copy link
Collaborator

@xsh310 xsh310 commented Dec 9, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Related Issues/PRs

What changes are proposed in this pull request?

For our newly created built-in judges that wraps an InstructionsJudge, the scorer_called event will fire twice when evaluation runs, once for the built-in judge's call and once for the InstructionsJudge's call. To prevent this, I'm moving the call logic for InstructionsJudge to a _evaluate_impl helper function instead and make the wrapped judges call _evaluate_impl to prevent duplicate events.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Manual Test

result = mlflow.genai.evaluate(
        data=_EVALUATION_TEST_CASES,
        predict_fn=predict_fn,
        scorers=[
                Completeness(), 
        ],
);
{'scorer_class': 'Completeness', 'scorer_kind': 'builtin', 'is_session_level_scorer': False, 'callsite': 'genai.evaluate', 'has_feedback_error': False}
x10

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@xsh310 xsh310 requested review from AveshCSingh, B-Step62, dbczumar, serena-ruan and smoorjani and removed request for B-Step62 and smoorjani December 9, 2025 07:16
@xsh310 xsh310 marked this pull request as ready for review December 9, 2025 07:17
@xsh310 xsh310 requested a review from B-Step62 December 9, 2025 07:17
@github-actions github-actions bot added area/evaluation MLflow Evaluation area/tracking Tracking service, tracking client APIs, autologging rn/none List under Small Changes in Changelogs. labels Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Documentation preview for c02aaea is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Copy link
Collaborator

@AveshCSingh AveshCSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff from the base PR LGTM. Please wait for Serena's approval on the base PR before merging.

@xsh310 xsh310 force-pushed the stack/ML-59817-address-double-call-events-for-wrapped-builtin-scorers branch 3 times, most recently from 2248ff1 to 26f0c83 Compare December 11, 2025 16:19
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To include this in 3.8.0, please add v3.8.0 label :)

@xsh310 xsh310 added the v3.8.0 label Dec 12, 2025
Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
@xsh310 xsh310 force-pushed the stack/ML-59817-address-double-call-events-for-wrapped-builtin-scorers branch from 26f0c83 to c02aaea Compare December 12, 2025 02:48
@xsh310 xsh310 enabled auto-merge December 12, 2025 02:50
@xsh310 xsh310 added this pull request to the merge queue Dec 12, 2025
Merged via the queue into mlflow:master with commit 1c10f10 Dec 12, 2025
49 checks passed
@xsh310 xsh310 deleted the stack/ML-59817-address-double-call-events-for-wrapped-builtin-scorers branch December 12, 2025 03:27
debu-sinha pushed a commit to debu-sinha/mlflow that referenced this pull request Dec 12, 2025
…ers (mlflow#19288)

Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation area/tracking Tracking service, tracking client APIs, autologging rn/none List under Small Changes in Changelogs. v3.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants