[ML-59817] Address double scorer call events for wrapped builtin scorers#19288
Merged
xsh310 merged 1 commit intomlflow:masterfrom Dec 12, 2025
Conversation
29 tasks
Contributor
|
Documentation preview for c02aaea is available at: More info
|
AveshCSingh
approved these changes
Dec 9, 2025
Collaborator
AveshCSingh
left a comment
There was a problem hiding this comment.
The diff from the base PR LGTM. Please wait for Serena's approval on the base PR before merging.
2248ff1 to
26f0c83
Compare
serena-ruan
approved these changes
Dec 12, 2025
Collaborator
serena-ruan
left a comment
There was a problem hiding this comment.
To include this in 3.8.0, please add v3.8.0 label :)
Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
26f0c83 to
c02aaea
Compare
debu-sinha
pushed a commit
to debu-sinha/mlflow
that referenced
this pull request
Dec 12, 2025
…ers (mlflow#19288) Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Related Issues/PRs
What changes are proposed in this pull request?
For our newly created built-in judges that wraps an
InstructionsJudge, the scorer_called event will fire twice when evaluation runs, once for the built-in judge's call and once for theInstructionsJudge's call. To prevent this, I'm moving the call logic forInstructionsJudgeto a_evaluate_implhelper function instead and make the wrapped judges call_evaluate_implto prevent duplicate events.How is this PR tested?
Manual Test
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.