Skip to content

[BUG FIX] Add is_session_level-scorer flag to scorer serialization#19171

Merged
xsh310 merged 1 commit intomlflow:masterfrom
xsh310:stack/add-session-level-flag-to-scorer-serialization
Dec 2, 2025
Merged

[BUG FIX] Add is_session_level-scorer flag to scorer serialization#19171
xsh310 merged 1 commit intomlflow:masterfrom
xsh310:stack/add-session-level-flag-to-scorer-serialization

Conversation

@xsh310
Copy link
Collaborator

@xsh310 xsh310 commented Dec 2, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19171/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19171/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19171/merge

🥞 Stacked PR

Use this link to review incremental changes.


What changes are proposed in this pull request?

Adding is_session_level_scorer property to scorer serialization so that this can be parsed by the UI client.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

All of the following passes:

python -m pytest tests/genai/judges/test_make_judge.py -v
python -m pytest tests/genai/scorers/test_scorer.py -v
python -m pytest tests/genai/judges/test_builtin.py -v

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
@xsh310 xsh310 requested review from B-Step62 and smoorjani December 2, 2025 19:34
@github-actions github-actions bot added area/evaluation MLflow Evaluation rn/none List under Small Changes in Changelogs. labels Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Documentation preview for 22651d3 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@dbczumar dbczumar added the v3.7.0 label Dec 2, 2025
@dbczumar dbczumar changed the title Add is_session_level-scorer flag to scorer serialization [BUG FIX] Add is_session_level-scorer flag to scorer serialization Dec 2, 2025
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xsh310 xsh310 added this pull request to the merge queue Dec 2, 2025
Merged via the queue into mlflow:master with commit b14d20a Dec 2, 2025
63 of 68 checks passed
@xsh310 xsh310 deleted the stack/add-session-level-flag-to-scorer-serialization branch December 2, 2025 20:26
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Dec 4, 2025
BenWilson2 pushed a commit that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation rn/none List under Small Changes in Changelogs. v3.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants