Fix OTLP endpoint path handling per OpenTelemetry spec#19154
Merged
harupy merged 1 commit intomlflow:masterfrom Dec 2, 2025
Merged
Fix OTLP endpoint path handling per OpenTelemetry spec#19154harupy merged 1 commit intomlflow:masterfrom
harupy merged 1 commit intomlflow:masterfrom
Conversation
Per the OTel spec, OTEL_EXPORTER_OTLP_ENDPOINT is a base URL that requires appending the signal path (/v1/traces or /v1/metrics), while signal-specific endpoints (OTEL_EXPORTER_OTLP_TRACES_ENDPOINT, OTEL_EXPORTER_OTLP_METRICS_ENDPOINT) should be used as-is. The previous implementation passed both values directly to the SDK without appending the path for the base endpoint case. This worked by accident because the SDK only appends the path when it reads environment variables itself, not when an explicit endpoint argument is passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
|
Documentation preview for 880cdca is available at: More info
|
serena-ruan
approved these changes
Dec 2, 2025
Collaborator
serena-ruan
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix!
BenWilson2
pushed a commit
to BenWilson2/mlflow
that referenced
this pull request
Dec 4, 2025
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
BenWilson2
pushed a commit
that referenced
this pull request
Dec 4, 2025
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
What changes are proposed in this pull request?
Per the OTel spec:
OTEL_EXPORTER_OTLP_TRACES_ENDPOINT/OTEL_EXPORTER_OTLP_METRICS_ENDPOINT: Full URL used as-isOTEL_EXPORTER_OTLP_ENDPOINT: Base URL, requires appending signal path (/v1/tracesor/v1/metrics)The previous implementation passed both values directly to the SDK without appending the path for the base endpoint case. This worked by accident because the SDK only appends the path when it reads environment variables itself, not when an explicit
endpointargument is passed.How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Fix OTLP endpoint path handling to correctly append
/v1/tracesor/v1/metricswhen usingOTEL_EXPORTER_OTLP_ENDPOINTbase URL.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityHow should the PR be classified in the release notes? Choose one:
rn/bug-fix- A user-facing bug fix worth mentioning in the release notesShould this PR be included in the next patch release?
🤖 Generated with Claude Code