Skip to content

Add test for return_full_text when saving prompt_template#19148

Merged
BenWilson2 merged 2 commits intomlflow:masterfrom
ingo-stallknecht:tests/transformers-prompt-template
Dec 4, 2025
Merged

Add test for return_full_text when saving prompt_template#19148
BenWilson2 merged 2 commits intomlflow:masterfrom
ingo-stallknecht:tests/transformers-prompt-template

Conversation

@ingo-stallknecht
Copy link
Contributor

@ingo-stallknecht ingo-stallknecht commented Dec 2, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19148/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19148/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19148/merge

Related Issues/PRs

None

What changes are proposed in this pull request?

This PR adds a small unit test to tests/transformers/test_transformers_model_export.py.
The test verifies that calling mlflow.transformers.log_model with a prompt_template correctly sets
return_full_text=False for text-generation pipelines.
This mirrors the documented behavior and protects against regressions.
Only one file is touched and the change is minimal by design.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions github-actions bot added the v3.7.0 label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

@ingo-stallknecht Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/models MLmodel format, model serialization/deserialization, flavors area/prompts MLflow Prompt Registry and Optimization rn/none List under Small Changes in Changelogs. labels Dec 2, 2025
@ingo-stallknecht ingo-stallknecht force-pushed the tests/transformers-prompt-template branch from 13032b3 to 89a31d2 Compare December 2, 2025 01:36
Signed-off-by: Ingo Stallknecht <ingostallknecht@gmail.com>
@ingo-stallknecht ingo-stallknecht force-pushed the tests/transformers-prompt-template branch from 0e9cadd to 335e0b3 Compare December 3, 2025 20:01
@ingo-stallknecht
Copy link
Contributor Author

I’ve amended the last commit and force-pushed to retrigger CI.
The other workflows have re-run, but the lint/protect status is still showing as “Required” and hasn’t started.

Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit - once addressed, we'll merge! Thanks for adding this :)

Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Signed-off-by: Ingo Stallknecht <ingostallknecht@gmail.com>
@ingo-stallknecht
Copy link
Contributor Author

Done.

@BenWilson2 BenWilson2 added this pull request to the merge queue Dec 4, 2025
Merged via the queue into mlflow:master with commit 926fd14 Dec 4, 2025
72 of 74 checks passed
BenWilson2 added a commit to BenWilson2/mlflow that referenced this pull request Dec 4, 2025
Signed-off-by: Ingo Stallknecht <ingostallknecht@gmail.com>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
BenWilson2 added a commit that referenced this pull request Dec 4, 2025
Signed-off-by: Ingo Stallknecht <ingostallknecht@gmail.com>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/models MLmodel format, model serialization/deserialization, flavors area/prompts MLflow Prompt Registry and Optimization rn/none List under Small Changes in Changelogs. v3.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants