Skip to content

Fix routing conflict when invoking get_trace on older MLflow servers#19130

Merged
serena-ruan merged 1 commit intomlflow:masterfrom
serena-ruan:fix_get_trace
Dec 4, 2025
Merged

Fix routing conflict when invoking get_trace on older MLflow servers#19130
serena-ruan merged 1 commit intomlflow:masterfrom
serena-ruan:fix_get_trace

Conversation

@serena-ruan
Copy link
Collaborator

@serena-ruan serena-ruan commented Dec 1, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19130/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/19130/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/19130/merge

Related Issues/PRs

Fix get_trace backwards compatibility, the path is routed to GET /mlflow/traces/{trace_id} as GetTraceInfoV3 for old mlflow server. The fix catches the error message within rest_store and raise unimplementedError and caught by downstream, fixes mlflow.get_trace issue.

#xxx

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@github-actions github-actions bot added v3.7.0 rn/none List under Small Changes in Changelogs. labels Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Documentation preview for 505d78d is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@serena-ruan serena-ruan added the team-review Trigger a team review request label Dec 2, 2025
@serena-ruan serena-ruan changed the title Fix get trace Fix routing conflict when invoking get_trace on older MLflow servers Dec 2, 2025
harupy
harupy previously approved these changes Dec 2, 2025
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serena-ruan serena-ruan added this pull request to the merge queue Dec 4, 2025
Merged via the queue into mlflow:master with commit 3c84207 Dec 4, 2025
58 of 63 checks passed
@serena-ruan serena-ruan deleted the fix_get_trace branch December 4, 2025 00:40
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Dec 4, 2025
BenWilson2 pushed a commit that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs. team-review Trigger a team review request v3.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants