Skip to content

Throw exception for session-level judge align API at the base judge level instead of built-in judge level#19045

Merged
xsh310 merged 4 commits intomlflow:masterfrom
xsh310:stack/multi_turn_judge_align_handling_fix
Nov 26, 2025
Merged

Throw exception for session-level judge align API at the base judge level instead of built-in judge level#19045
xsh310 merged 4 commits intomlflow:masterfrom
xsh310:stack/multi_turn_judge_align_handling_fix

Conversation

@xsh310
Copy link
Collaborator

@xsh310 xsh310 commented Nov 26, 2025

🥞 Stacked PR

Use this link to review incremental changes.


What changes are proposed in this pull request?

Currently the NotImplementedError for the align API for session-level judge is raised from the newly created BuiltInScorers. But we also want to raise the exception for session_level judge created via make_judge. This PR moves the exception to the base judge class to cover both BuiltInScorer and InstructionsJudge created via make_judge.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Test Plan

Passed new unit test: test_session_level_scorer_alignment_raises_error

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
…evel instead of built-in judge level

Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
@xsh310 xsh310 force-pushed the stack/multi_turn_judge_align_handling_fix branch from 26ccac3 to 24ba45a Compare November 26, 2025 07:23
@github-actions github-actions bot added v3.6.1 area/evaluation MLflow Evaluation rn/none List under Small Changes in Changelogs. labels Nov 26, 2025
@github-actions
Copy link
Contributor

Documentation preview for 24ba45a is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xsh310 xsh310 enabled auto-merge November 26, 2025 08:23
@xsh310 xsh310 added this pull request to the merge queue Nov 26, 2025
Merged via the queue into mlflow:master with commit e3e7b89 Nov 26, 2025
69 of 75 checks passed
@xsh310 xsh310 deleted the stack/multi_turn_judge_align_handling_fix branch November 26, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation rn/none List under Small Changes in Changelogs. v3.6.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants