[Endpoints] [6/x] Protos and entities interfaces#19007
Merged
BenWilson2 merged 1 commit intomlflow:masterfrom Dec 6, 2025
Merged
[Endpoints] [6/x] Protos and entities interfaces#19007BenWilson2 merged 1 commit intomlflow:masterfrom
BenWilson2 merged 1 commit intomlflow:masterfrom
Conversation
This was referenced Nov 24, 2025
c2e8971 to
39c18ad
Compare
aee9e55 to
06d6412
Compare
This was referenced Nov 26, 2025
06d6412 to
e74180a
Compare
29 tasks
2a1d06c to
cf027d4
Compare
Contributor
|
Documentation preview for e6dbf67 is available at: More info
|
2c91f2a to
9f2c116
Compare
81349ca to
2baff68
Compare
TomeHirata
approved these changes
Dec 5, 2025
Collaborator
TomeHirata
left a comment
There was a problem hiding this comment.
Left some comments, otherwise LGTM
| @@ -38,7 +37,7 @@ | |||
| from mlflow.utils.time import get_current_time_millis | |||
|
|
|||
| if TYPE_CHECKING: | |||
Collaborator
There was a problem hiding this comment.
Let's remove the TYPE_CHECKING entirely
| sql_model_def.name = name | ||
| if secret_id is not None: | ||
| _ = self._get_entity_or_404(session, SqlGatewaySecret, {"secret_id": secret_id}, "GatewaySecret") | ||
| _ = self._get_entity_or_404( |
mlflow/protos/service.proto
Outdated
| message Response {} | ||
| } | ||
|
|
||
| message ListGatewaySecrets { |
Collaborator
There was a problem hiding this comment.
Following up with our conversation in another pr, let's add "Info" to this message
| path: "/mlflow/secrets/create" | ||
| since: { | ||
| major: 3 | ||
| minor: 0 |
Collaborator
There was a problem hiding this comment.
Curious, is it our convention to always use 0 for minor version?
cccecea to
b56e2b3
Compare
b56e2b3 to
ff92642
Compare
ff92642 to
e6dbf67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Add the proto definitions and define the entities interfaces for protos
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.