Skip to content

[ML-59815] Use class name instead of scorer name in genai_evaluate telemetry event#18990

Merged
xsh310 merged 1 commit intomlflow:masterfrom
xsh310:stack/ML-59815
Nov 24, 2025
Merged

[ML-59815] Use class name instead of scorer name in genai_evaluate telemetry event#18990
xsh310 merged 1 commit intomlflow:masterfrom
xsh310:stack/ML-59815

Conversation

@xsh310
Copy link
Collaborator

@xsh310 xsh310 commented Nov 24, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Currently we log all the name of the BuiltInScorer passed into the mlflow.genai.evaluate, which can included user-defined scorer name, especially for Guidelines judge which extends BuiltInScorer and typically user will defined a custom scorer name. Synced with @B-Step62 before, we should remove these user-defined scorer name in our OSS telemetry. In this PR, I'm changing it from the name to the name of the scorer class to remove user-defined names.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Manual Test Plan

Invoke the following code snippet

from mlflow.genai.scorers import Safety, RelevanceToQuery, Guidelines

result = mlflow.genai.evaluate(
        data=_EVALUATION_TEST_CASES,
        predict_fn=predict_fn,
        scorers=[Safety(name="my_secret_app's_safety_scorer"), RelevanceToQuery(), Guidelines(
                name="test_guidelines",
                guidelines=["The response must be helpful and accurate"],
        )],
);

Printing the genai_evaluate's record_params

Before After
Logged telemetry event: genai_evaluate, record_params: {'builtin_scorers': ['test_guidelines', 'relevance_to_query', "my_secret_app's_safety_scorer"]} Logged telemetry event: genai_evaluate, record_params: {'builtin_scorers': ['Guidelines', 'RelevanceToQuery', 'Safety']}

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Documentation preview for b520975 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@github-actions github-actions bot added area/evaluation MLflow Evaluation rn/none List under Small Changes in Changelogs. v3.6.1 labels Nov 24, 2025
Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…lemetry event

Signed-off-by: Xiang Shen <xshen.shc@gmail.com>
@xsh310 xsh310 enabled auto-merge November 24, 2025 16:50
@xsh310 xsh310 added this pull request to the merge queue Nov 24, 2025
Merged via the queue into mlflow:master with commit 3bd2f60 Nov 24, 2025
49 of 51 checks passed
@xsh310 xsh310 deleted the stack/ML-59815 branch November 24, 2025 17:28
@xsh310 xsh310 restored the stack/ML-59815 branch November 25, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/evaluation MLflow Evaluation rn/none List under Small Changes in Changelogs. v3.6.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants