Skip to content

Enable FURB192 linting rule to enforce min/max over sorted#18980

Merged
harupy merged 2 commits intomasterfrom
copilot/enable-furb192-rule
Nov 24, 2025
Merged

Enable FURB192 linting rule to enforce min/max over sorted#18980
harupy merged 2 commits intomasterfrom
copilot/enable-furb192-rule

Conversation

Copy link
Contributor

Copilot AI commented Nov 23, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Enabled ruff rule FURB192 which detects inefficient uses of sorted() when computing min/max values. Replaced O(n log n) sorting with O(n) min/max operations:

# Before
version = sorted(versions)[-1]
latest = sorted(candidates, key=Version, reverse=True)[0]
first = sorted(items)[0]

# After
version = max(versions)
latest = max(candidates, key=Version)
first = min(items)

Files modified:

  • pyproject.toml: Added FURB192 to linting rules
  • dev/set_matrix.py, dev/update_ml_package_versions.py: Changed to max()
  • mlflow/utils/virtualenv.py: Changed to max() with Version key
  • tests/pyfunc/docker/conftest.py: Changed to max()
  • tests/spark/autologging/datasource/conftest.py: Changed to min() for tuple unpacking

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Verified behavior correctness with manual tests for Version comparison and tuple min operations.

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Enable FURB192. Run ruff rule FURB192 to see what this rule enforces. Once enabled, run ruff check and fix any reported violations


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 23, 2025
@harupy harupy marked this pull request as ready for review November 23, 2025 11:03
@github-actions
Copy link
Contributor

@Copilot Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable FURB192 rule and fix violations Enable FURB192 linting rule to enforce min/max over sorted Nov 23, 2025
Copilot AI requested a review from harupy November 23, 2025 11:12
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Nov 23, 2025
@harupy harupy merged commit 7076876 into master Nov 24, 2025
415 of 445 checks passed
@harupy harupy deleted the copilot/enable-furb192-rule branch November 24, 2025 00:47
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants