Skip to content

Enable FURB110 ruff rule (if-exp-instead-of-or-operator)#18979

Merged
harupy merged 2 commits intomasterfrom
copilot/enable-furb110-rule
Nov 23, 2025
Merged

Enable FURB110 ruff rule (if-exp-instead-of-or-operator)#18979
harupy merged 2 commits intomasterfrom
copilot/enable-furb110-rule

Conversation

Copy link
Contributor

Copilot AI commented Nov 23, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Enables the FURB110 ruff rule which replaces verbose ternary expressions x if x else y with the idiomatic x or y.

Changes:

  • Added FURB110 to ruff's select list in pyproject.toml
  • Auto-fixed 40 violations across 29 files

Example transformations:

# Before
profile = profile if profile else DEFAULT_SECTION
max_results = request_message.max_results if request_message.max_results else 1000

# After  
profile = profile or DEFAULT_SECTION
max_results = request_message.max_results or 1000

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Enable FURB110. Run ruff rule FURB110 to see what this rule enforces. Once eanbled, run ruff check and fix any reported violations. Use ruff check --fix if it's auto-fixable


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 23, 2025
@harupy harupy marked this pull request as ready for review November 23, 2025 08:25
@github-actions
Copy link
Contributor

@Copilot Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable FURB110 and fix reported violations Enable FURB110 ruff rule (if-exp-instead-of-or-operator) Nov 23, 2025
Copilot AI requested a review from harupy November 23, 2025 08:33
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Nov 23, 2025
@harupy harupy merged commit 1384ef4 into master Nov 23, 2025
75 of 101 checks passed
@harupy harupy deleted the copilot/enable-furb110-rule branch November 23, 2025 09:28
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants