Skip to content

Enable RUF039 linting rule for raw regex strings#18974

Merged
harupy merged 2 commits intomasterfrom
copilot/enable-ruf039-in-pyproject
Nov 23, 2025
Merged

Enable RUF039 linting rule for raw regex strings#18974
harupy merged 2 commits intomasterfrom
copilot/enable-ruf039-in-pyproject

Conversation

Copy link
Contributor

Copilot AI commented Nov 22, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18974/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18974/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18974/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Enables RUF039 (unraw-re-pattern) which enforces raw strings for regex patterns to prevent double-escaping bugs.

Changes:

  • Added RUF039 to ruff lint rules in pyproject.toml
  • Fixed 4 violations by converting regex strings to raw strings:
    • mlflow/pyspark/ml/_autolog.py: re.search() pattern
    • mlflow/store/artifact/mlflow_artifacts_repo.py: re.sub() pattern
    • mlflow/utils/uri.py: re.sub() pattern
    • tests/utils/test_logging_utils.py: re.compile() pattern

Example fix:

# Before
re.sub("//+", "/", resolved)

# After
re.sub(r"//+", "/", resolved)

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Enable RUF039 in pyproject.toml. Use ruff rule to see what this rulrle enforces. Once enabled, run ruff check and fix any reported violations


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Added RUF039 (unraw-re-pattern) to pyproject.toml select list
- Fixed 4 violations by converting non-raw strings to raw strings in regex patterns:
  - mlflow/pyspark/ml/_autolog.py: re.search pattern
  - mlflow/store/artifact/mlflow_artifacts_repo.py: re.sub pattern
  - mlflow/utils/uri.py: re.sub pattern
  - tests/utils/test_logging_utils.py: re.compile pattern

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable RUF039 rule in pyproject.toml Enable RUF039 linting rule for raw regex strings Nov 22, 2025
Copilot AI requested a review from harupy November 22, 2025 12:40
@harupy harupy marked this pull request as ready for review November 23, 2025 00:57
@github-actions
Copy link
Contributor

Documentation preview for 4e1eab8 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Nov 23, 2025
@harupy harupy added this pull request to the merge queue Nov 23, 2025
Merged via the queue into master with commit 2ace656 Nov 23, 2025
116 of 122 checks passed
@harupy harupy deleted the copilot/enable-ruf039-in-pyproject branch November 23, 2025 07:56
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants