Fix bash array expansion in workflow files to pass prompts as single argument#18969
Merged
Fix bash array expansion in workflow files to pass prompts as single argument#18969
Conversation
Contributor
|
@Copilot Thank you for the contribution! Could you fix the following issue(s)? ⚠ Invalid PR templateThis PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out. |
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update review.yml and resolve.yml to use "${ARGS[*]}"
Fix bash array expansion in workflow files to pass prompts as single argument
Nov 22, 2025
harupy
approved these changes
Nov 22, 2025
Tian-Sky-Lan
pushed a commit
to Tian-Sky-Lan/mlflow
that referenced
this pull request
Nov 24, 2025
…argument (mlflow#18969) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Changed bash array expansion from
"${ARGS[@]}"to"${ARGS[*]}"inreview.ymlandresolve.ymlworkflow files.Behavior change:
"${ARGS[@]}"expands each array element as separate arguments →claude cmd '/pr-review' 'Please review the code'(2 args)"${ARGS[*]}"expands all elements as single argument →claude cmd '/pr-review Please review the code'(1 arg)This ensures user prompts with spaces are passed intact to the claude CLI rather than being word-split.
Files changed:
.github/workflows/review.ymlline 111.github/workflows/resolve.ymlline 150How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/build: Build and test infrastructure for MLflowHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionShould this PR be included in the next patch release?
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.