Sort documentation pages alphabetically in preview comments#18948
Sort documentation pages alphabetically in preview comments#18948
Conversation
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
|
@Copilot Thank you for the contribution! Could you fix the following issue(s)? ⚠ Invalid PR templateThis PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out. |
|
@copilot update the PR description following pull_request_template.md |
Updated the PR description to follow the pull_request_template.md format. The description now includes all required sections: Related Issues/PRs, What changes are proposed, How is this PR tested, Documentation update section, and Release Notes with appropriate component and classification selections. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the usability of documentation preview comments by sorting changed documentation pages alphabetically by their path, making it easier to locate specific pages when multiple documentation files are modified.
Key Changes:
- Added alphabetical sorting to the
getChangedDocPagesfunction usinglocaleCompare() - Updated JSDoc documentation to reflect that returned pages are sorted alphabetically
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…8948) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Kevin Wang <kevinwang2040@gmail.com>
…8948) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
…8948) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
This PR updates the
getChangedDocPagesfunction in.github/workflows/preview-comment.jsto alphabetically sort the returned documentation pages by path. This makes it easier for users to look up specific changed documentation pages in PR comments, especially when there are many changes.Changes:
.sort((a, b) => a.page.localeCompare(b.page))to sort pages alphabetically after collecting themExample output (before - unsorted):
Example output (after - sorted):
How is this PR tested?
Manual testing:
Created comprehensive test scripts that verify:
apicomes beforeapi/python)classic-ml→ml)Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yesshould be selected for bug fixes, documentation updates, and other small changes.Noshould be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.