Skip to content

MLflow UI sync#18945

Merged
danielseong1 merged 7 commits intomlflow:masterfrom
danielseong1:9vkkfrbc
Nov 21, 2025
Merged

MLflow UI sync#18945
danielseong1 merged 7 commits intomlflow:masterfrom
danielseong1:9vkkfrbc

Conversation

@danielseong1
Copy link
Collaborator

@danielseong1 danielseong1 commented Nov 20, 2025 •
edited
Loading

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18945/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18945/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18945/merge

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@mlflow-app @danielseong1
Project import generated by Copybara.
b53396e 
GitOrigin-RevId: 783f4b6b59b8165f89f9064d05cd75ecfe5d97f5
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

@danielseong1 Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs. labels Nov 20, 2025
@danielseong1
Reconcile changes from universe with OSS
f3e0b21 
Signed-off-by: daniel-seong_data <daniel.seong@databricks.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025 •
edited
Loading

Documentation preview for ce274f3 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

daniellok-db
daniellok-db reviewed Nov 21, 2025
View reviewed changes
daniellok-db
daniellok-db reviewed Nov 21, 2025
View reviewed changes
daniellok-db
daniellok-db reviewed Nov 21, 2025
View reviewed changes
Daniel Seong added 2 commits November 20, 2025 19:41
address comments
5a75062 
Signed-off-by: Daniel Seong <daniel.leem.seong@gmail.com>
resync yarn.lock
a7f9229 
Signed-off-by: Daniel Seong <daniel.leem.seong@gmail.com>
daniellok-db
daniellok-db approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Daniel Seong added 2 commits November 20, 2025 19:54
Run prettier to fix formatting
b0d7763 
Signed-off-by: Daniel Seong <daniel.leem.seong@gmail.com>
Update test files
e33a4e7 
Signed-off-by: Daniel Seong <daniel.leem.seong@gmail.com>
@daniellok-db
Copy link
Collaborator

daniellok-db commented Nov 21, 2025 •
edited
Loading

discovered a bug but i think we can address this as a followup:

Screenshot 2025-11-21 at 5 53 30 PM

due to <Link> in OSS not supporting the asChild prop, the styling is different and causes the rows to get messed up. however it's a simple fix (just move Link in GenAIChatSessionsTable.tsx within the cell)

@claude
Fix chat sessions table row styling by moving Link inside TableCell
ce274f3 
The Link component in OSS doesn't support the asChild prop, which was
causing styling issues when it wrapped the TableCell. This fix moves
the Link component inside the TableCell to maintain proper row layout
and styling.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Daniel Seong <daniel.leem.seong@gmail.com>
@danielseong1
Copy link
Collaborator Author

danielseong1 commented Nov 21, 2025

discovered a bug but i think we can address this as a followup:

Screenshot 2025-11-21 at 5 53 30 PM due to `` in OSS not supporting the `asChild` prop, the styling is different and causes the rows to get messed up. however it's a simple fix (just move Link in `GenAIChatSessionsTable.tsx` within the cell)

fixed it here!

@danielseong1 danielseong1 added this pull request to the merge queue Nov 21, 2025
Merged via the queue into mlflow:master with commit 7d32fb4 Nov 21, 2025
52 of 54 checks passed
@danielseong1 danielseong1 deleted the 9vkkfrbc branch November 21, 2025 22:10
jimilp7 pushed a commit to backspace-org/mlflow that referenced this pull request Nov 21, 2025
@danielseong1 @mlflow-app
@claude @jimilp7
MLflow UI sync (mlflow#18945)
f006aee 
Signed-off-by: daniel-seong_data <daniel.seong@databricks.com>
Signed-off-by: Daniel Seong <daniel.leem.seong@gmail.com>
Co-authored-by: MLflow App <mlflow-app[bot]@users.noreply.github.com>
Co-authored-by: Daniel Seong <daniel.leem.seong@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
@danielseong1 @mlflow-app
@claude @Tian-Sky-Lan
MLflow UI sync (mlflow#18945)
183f739 
Signed-off-by: daniel-seong_data <daniel.seong@databricks.com>
Signed-off-by: Daniel Seong <daniel.leem.seong@gmail.com>
Co-authored-by: MLflow App <mlflow-app[bot]@users.noreply.github.com>
Co-authored-by: Daniel Seong <daniel.leem.seong@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniellok-db daniellok-db daniellok-db approved these changes

Assignees

No one assigned

Labels

allow-whitespace-only area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/none List under Small Changes in Changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielseong1 @daniellok-db