Skip to content

Enable ruff preview features and fix all reported issues#18940

Merged
harupy merged 4 commits intomasterfrom
copilot/add-preview-features-and-fix-imports
Nov 20, 2025
Merged

Enable ruff preview features and fix all reported issues#18940
harupy merged 4 commits intomasterfrom
copilot/add-preview-features-and-fix-imports

Conversation

Copy link
Contributor

Copilot AI commented Nov 20, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

This PR enables ruff preview mode and fixes all 29 linting violations detected. The changes are minimal and surgical:

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Verified with ruff check . (0 errors), pre-commit hooks (all pass), and sample unit tests from modified files (e.g., tests/utils/test_uri.py, tests/store/tracking/test_file_store.py).

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Add preview = true in tool.ruff.lint section of pyproject.toml to enalble preview features/rules. Once enabled, run ruff check . and fix any issues reported by ruff. E265 and E266 can be ignored. Use ruff rule to check their names/descriptions.

I notcied ruff incorrectly identifying docker as a first-party module. To fix this, add docker to the known-third-party list in the tool.ruff.lint.isort section of pyproject.toml:

[tool.ruff.lint.isort]
...
# <insert comment with https://docs.astral.sh/ruff/faq/#how-does-ruff-determine-which-of-my-imports-are-first-party-third-party-etc >
known-third-party = ["docker"]

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@harupy harupy marked this pull request as ready for review November 20, 2025 13:08
@github-actions
Copy link
Contributor

@Copilot Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add preview feature in tool.ruff.lint section Enable ruff preview features and fix all reported issues Nov 20, 2025
Copilot AI requested a review from harupy November 20, 2025 13:16
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI requested a review from harupy November 20, 2025 13:31
@harupy
Copy link
Member

harupy commented Nov 20, 2025

@copilot LGTM, Let's update the PR description

Copy link
Contributor Author

Copilot AI commented Nov 20, 2025

@copilot LGTM, Let's update the PR description

Updated the PR description to clarify that the docker directory in the repository root causes the misclassification issue.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI requested a review from harupy November 20, 2025 13:50
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Nov 20, 2025
@harupy harupy enabled auto-merge November 20, 2025 14:05
@harupy harupy disabled auto-merge November 20, 2025 14:34
@harupy harupy merged commit 11dec09 into master Nov 20, 2025
64 of 97 checks passed
@harupy harupy deleted the copilot/add-preview-features-and-fix-imports branch November 20, 2025 14:36
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow-whitespace-only area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants