Pin database Docker images and show digests in CI#18903
Merged
harupy merged 3 commits intomlflow:masterfrom Nov 19, 2025
Merged
Pin database Docker images and show digests in CI#18903harupy merged 3 commits intomlflow:masterfrom
harupy merged 3 commits intomlflow:masterfrom
Conversation
Add --digests flag to docker images command to display SHA256 digests. This helps track exact image versions and identify when MSSQL image updates cause schema constraint name changes. Also update MSSQL schema file to reflect constraint names from the latest MSSQL Docker image (mcr.microsoft.com/mssql/server). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
harupy
commented
Nov 19, 2025
Member
Author
There was a problem hiding this comment.
The latest tag of the mssql image was updated yesterday:
https://mcr.microsoft.com/en-us/artifact/mar/mssql/server/tag/latest
Pin mcr.microsoft.com/mssql/server to specific digest to prevent automatic updates from changing SQL Server's auto-generated foreign key constraint names. Digest: sha256:54b23ca766287dab5f6f55162923325f07cdec6ccb42108f37c55c87e7688ebd Image ID: 55c3fe0f8428 (1.79GB) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Pin all database Docker images to specific digests for consistency: - postgres: sha256:c1f0abd909b477d6088c72e4cd6eb01ea525344caca1b58689ae884204369502 - mysql: sha256:569c4128dfa625ac2ac62cdd8af588a3a6a60a049d1a8d8f0fac95880ecdbbe5 This prevents automatic updates from introducing unexpected schema or behavior changes across all database backends. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
commented
Nov 19, 2025
|
|
||
| mssql: | ||
| image: mcr.microsoft.com/mssql/server | ||
| image: mcr.microsoft.com/mssql/server@sha256:54b23ca766287dab5f6f55162923325f07cdec6ccb42108f37c55c87e7688ebd |
Member
Author
There was a problem hiding this comment.
Added digest to pin the image
BenWilson2
approved these changes
Nov 19, 2025
Member
BenWilson2
left a comment
There was a problem hiding this comment.
Fantastic solution. We should probably give proper aliases to those FKEYs some day... just so that don't have these crazy auto-generated names. This approach looks great as a workaround for now (we'll eventually need to update the images due to security reports / CVEs of older images or when MSFT takes them down I imagine)
mprahl
pushed a commit
to opendatahub-io/mlflow
that referenced
this pull request
Nov 21, 2025
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Tian-Sky-Lan
pushed a commit
to Tian-Sky-Lan/mlflow
that referenced
this pull request
Nov 24, 2025
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR addresses MSSQL schema instability caused by Docker image updates and improves CI observability:
--digestsflag to show SHA256 digests in CI logsBackground
MSSQL Docker image was recently updated from
a2fbff321505(1.61GB) to55c3fe0f8428(1.79GB):→
SQL Server auto-generates foreign key constraint names with hex suffixes based on internal object IDs. When the Docker image updates, these IDs change, resulting in different constraint names even though the schema structure remains identical.
Example constraint name changes:
FK__experimen__exper__4F7CD00D→FK__experimen__exper__628FA481FK__model_vers__name__5812160E→FK__model_vers__name__6B24EA82Pinned image digests
All database images are now pinned to prevent future automatic updates:
sha256:c1f0abd909b477d6088c72e4cd6eb01ea525344caca1b58689ae884204369502sha256:569c4128dfa625ac2ac62cdd8af588a3a6a60a049d1a8d8f0fac95880ecdbbe5sha256:54b23ca766287dab5f6f55162923325f07cdec6ccb42108f37c55c87e7688ebdHow is this PR tested?
The MSSQL schema file is auto-generated during CI runs. This update ensures the checked-in schema matches the pinned Docker image.
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/build: Build and test infrastructure for MLflowHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionShould this PR be included in the next patch release?
🤖 Generated with Claude Code