Skip to content

Speed up R tests by using uv as env-manager instead of virtualenv#18882

Merged
harupy merged 6 commits intomasterfrom
copilot/update-mlflow-env-manager
Nov 18, 2025
Merged

Speed up R tests by using uv as env-manager instead of virtualenv#18882
harupy merged 6 commits intomasterfrom
copilot/update-mlflow-env-manager

Conversation

Copy link
Contributor

Copilot AI commented Nov 18, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

R tests using mlflow_cli("models", "predict") defaulted to virtualenv/pyenv which is extremely slow. This PR switches to uv for significantly faster test execution.

Changes:

  • Added --env-manager uv to all 11 mlflow_cli("models", "predict") calls across 3 R test files:
    • test-model.R (5 calls)
    • test-model-xgboost.R (3 calls)
    • test-model-h2o.R (3 calls)
  • Updated CLI help text to document uv as a supported option for --env-manager (was already implemented, just undocumented)
  • Updated --install-mlflow help text to mention uv alongside conda and virtualenv

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Verified CLI help displays correctly and uv is validated as a supported env_manager value.

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)
Original prompt

Some R tests use mlflow_cli("models", "predict" to invoke the CLI for model prediction. By default, pyenv is used as the environment manager but it's extremely slow. To speed up the tests, add --env-manager with uv


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@harupy harupy marked this pull request as ready for review November 18, 2025 07:55
@github-actions
Copy link
Contributor

@Copilot Thank you for the contribution! Could you fix the following issue(s)?

⚠ Invalid PR template

This PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out.

Copilot AI and others added 2 commits November 18, 2025 08:02
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI changed the title [WIP] Update R tests to use uv as env manager for speed Speed up R tests by using uv as env-manager instead of virtualenv Nov 18, 2025
Copilot AI requested a review from harupy November 18, 2025 08:11
@harupy harupy added the team-review Trigger a team review request label Nov 18, 2025
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow area/models MLmodel format, model serialization/deserialization, flavors rn/none List under Small Changes in Changelogs. labels Nov 18, 2025
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Documentation preview for 65475c1 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot AI requested a review from harupy November 18, 2025 08:44
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Copy link
Member

@harupy harupy Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Run tests step in the r job takes about 20 minutes. On this PR, it takes 6-7 minutes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to speed up iteration when fixing a bug.

@harupy harupy added this pull request to the merge queue Nov 18, 2025
Merged via the queue into master with commit dc1c148 Nov 18, 2025
48 of 50 checks passed
@harupy harupy deleted the copilot/update-mlflow-env-manager branch November 18, 2025 09:53
mprahl pushed a commit to opendatahub-io/mlflow that referenced this pull request Nov 21, 2025
…flow#18882)

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Tian-Sky-Lan pushed a commit to Tian-Sky-Lan/mlflow that referenced this pull request Nov 24, 2025
…flow#18882)

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Tian Lan <sky.blue266000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build and test infrastructure for MLflow area/models MLmodel format, model serialization/deserialization, flavors rn/none List under Small Changes in Changelogs. team-review Trigger a team review request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants